[GitHub] spark pull request: [SPARK-3877][YARN] Throw an exception when app...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/2732#issuecomment-59449285
  
    Hi @zsxwing, this looks good to me but I have two requests:
    
    - since now `run()` throws an exception on error, can you change `Client.scala` (both of them) so that they don't call `System.exit()` directly and instead let the exception bubble up?
    - once that's done, could you change `YarnClusterSuite.scala` so that it doesn't have the hacky way of calling the `Client` object, and also add a test to make sure cluster mode is exiting with a non-zero status on error?
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org