You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/04 10:25:19 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #37:
Improvements for NRF52
raiden00pl opened a new pull request #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #37: Improvements for
NRF52
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #37: Improvements
for NRF52
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570799199
Don't be tempted to change that with a simple substitution. That would mess up the alignment. It would require lots of manual effort or a very intelligent script. It looks like Xiao Xiang must have had such an intelligent script when he removed all of the (void). He also corrected all of the spacing that the that changed because of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #37:
Improvements for NRF52
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570942572
I don't have the magic script either:(: only single line functions are replaced by the command automatically, other functions spread the multiple lines are done manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] raiden00pl commented on issue #37: Improvements
for NRF52
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570787762
I think we still need support for SPI and GPIO interrupts to do something useful. I'll add them next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on a change in pull request
#37: Improvements for NRF52
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#discussion_r363031912
##########
File path: arch/arm/src/nrf52/nrf52_lowputc.c
##########
@@ -216,7 +216,7 @@ void nrf52_usart_configure(uintptr_t base, const struct uart_config_s *config)
****************************************************************************/
#ifdef HAVE_UART_DEVICE
-void nrf52_usart_disable(uintptr_t base)
+void nrf52_usart_disable(uintptr_t base, const struct uart_config_s *config)
Review comment:
Mateuz, I think it is a good idea to add FAR to all these "const struct uart_config_s *", what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #37: Improvements for
NRF52
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570798176
Well, it appears at least 15182 inside arch/arm:
alan@dev:~/incubator-nuttx/arch/arm$ grep -r "FAR " | wc -l
15182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request
#37: Improvements for NRF52
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#discussion_r363032825
##########
File path: arch/arm/src/nrf52/nrf52_lowputc.c
##########
@@ -216,7 +216,7 @@ void nrf52_usart_configure(uintptr_t base, const struct uart_config_s *config)
****************************************************************************/
#ifdef HAVE_UART_DEVICE
-void nrf52_usart_disable(uintptr_t base)
+void nrf52_usart_disable(uintptr_t base, const struct uart_config_s *config)
Review comment:
Yes, you are right. Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] raiden00pl commented on issue #37: Improvements
for NRF52
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570794215
At the moment in arch/nrf52 in some places there is FAR in some not. So for now it is far from consistent. But I think it is also true for other ARM chips.
If there is no strict rule (always use FAR vs never use FAR), then there will be not consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #37: Improvements for
NRF52
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570783029
Thank you Mateusz, please verify if everything is fine. Every nice improvements! I think now we can run NuttX on PineTime Watch and on other Watches/Bands powered by nRF52
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #37: Improvements
for NRF52
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570789186
@acassis FAR is not normally used in ARM code. It is only required in the common code where it needs to have a value for some architectures. It is fine in ARM code to assume that FAR is defined to be nothing. Everyone assumes that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #37: Improvements for
NRF52
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570790833
@patacongo You are right! I saw a FAR in a function that he submitted and assumed it should be presented for all functions. My fault!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #37: Improvements
for NRF52
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #37: Improvements for NRF52
URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570790945
@acassis Well, it should be used consistently in ARM code. Either always user FAR or never use it in an ARM file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services