You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/07 11:58:06 UTC

[GitHub] [incubator-iotdb] Genius-pig commented on a change in pull request #1700: [IOTDB-875]fix flush storage group error when no data in storage group

Genius-pig commented on a change in pull request #1700:
URL: https://github.com/apache/incubator-iotdb/pull/1700#discussion_r484386580



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##########
@@ -394,6 +413,15 @@ public void asyncCloseProcessor(PartialPath storageGroupPath, boolean isSeq)
         processor.writeUnlock();
       }
     } else {
+      // bug fix, for storage group do does not have data
+      // https://issues.apache.org/jira/browse/IOTDB-875
+      List<PartialPath> allStorageGroupPaths = MManager.getInstance()

Review comment:
       can you use `getStorageGroupPath` instead of getting all storage groups?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org