[GitHub] [sling-org-apache-sling-jcr-registration] ashokmca07 commented on a diff in pull request #2: SLING-11413: Upgrade to sling 48

[GitBox <gi...@apache.org>]

ashokmca07 commented on code in PR #2:
URL: https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/2#discussion_r905870507


##########
src/main/java/org/apache/sling/jcr/registration/impl/JndiRegistrationSupport.java:
##########
@@ -53,20 +55,17 @@
 @Component(
         configurationPolicy = ConfigurationPolicy.REQUIRE,
         name = "org.apache.sling.jcr.jackrabbit.server.JndiRegistrationSupport",
-        property = {
-                "service.vendor=The Apache Software Foundation",
-                "service.description=JNDI Repository Registration"
-        },
         reference = {
                 @Reference(name = "Repository", policy = ReferencePolicy.DYNAMIC,
-                        bind = "bindRepository", unbind = "unbindRepository",
                         cardinality = ReferenceCardinality.MULTIPLE, service = Repository.class),
                 @Reference(name = "Log", policy = ReferencePolicy.DYNAMIC,
                         bind = "bindLog", unbind = "unbindLog",
                         cardinality = ReferenceCardinality.OPTIONAL, service = LogService.class),
         }
 )
 @Designate(ocd = JndiRegistrationSupport.Configuration.class)
+@ServiceVendor("The Apache Software Foundation")

Review Comment:
   Removed ✅ 



##########
src/main/java/org/apache/sling/jcr/registration/impl/RmiRegistrationSupport.java:
##########
@@ -65,6 +63,8 @@
         }
 )
 @Designate(ocd = RmiRegistrationSupport.Configuration.class)
+@ServiceVendor("The Apache Software Foundation")

Review Comment:
   Removed ✅ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org