You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 02:38:50 UTC

[PR] fix(i18n): localize client connections page leftovers [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3237:
URL: https://github.com/apache/rocketmq-dashboard/pull/3237

   ## Summary
   
   The client connections page was localized except for its load-error fallback and the error-alert retry button.
   
   Localized in pages/cluster/clients.tsx:
   - The shared module-level zh error constant was removed; `getLoadErrorMessage` now takes a fallback and both call sites pass the localized `clients.loadFailed` text (the two effects list `t` in their deps).
   - The retry action uses the new `clients.retry` key.
   - 2 new `clients.*` keys; zh byte-identical.
   
   ## Why
   
   The page-level failure state and its retry action must follow the active language.
   
   ## Testing
   
   - `tsc --noEmit` passes
   - `eslint` clean on the changed files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(i18n): localize client connections page leftovers [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3237: fix(i18n): localize client connections page leftovers
URL: https://github.com/apache/rocketmq-dashboard/pull/3237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org