You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2017/07/28 11:38:34 UTC

[GitHub] spark pull request #18759: [SPARK-20601][ML] Python API for Constrained Logi...

GitHub user yanboliang opened a pull request:

    https://github.com/apache/spark/pull/18759

    [SPARK-20601][ML] Python API for Constrained Logistic Regression

    ## What changes were proposed in this pull request?
    Python API for Constrained Logistic Regression based on #17922 , thanks for the original contribution from @zero323 .
    
    ## How was this patch tested?
    Unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanboliang/spark SPARK-20601

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18759
    
----
commit c19f8ae64f4cab6f4cf4c797221b3d9d09451e0c
Author: zero323 <ze...@users.noreply.github.com>
Date:   2017-05-07T18:51:16Z

    Initial commit

commit c57964cac055287b23a898ab926be37241fc610e
Author: zero323 <ze...@users.noreply.github.com>
Date:   2017-05-09T11:17:00Z

    Fix style

commit 49b25010624bba7a85d93443e4e51a4f0e1b538c
Author: zero323 <ze...@users.noreply.github.com>
Date:   2017-05-09T15:23:25Z

    Change since 2.2.0 => 2.3.0

commit 649bf2843241f1ea7a4e6fd231355c4347118750
Author: zero323 <ze...@users.noreply.github.com>
Date:   2017-05-09T15:24:55Z

    Correct typo

commit f5e6cfbf50454c113bf9946832b2d4bf942bc9e9
Author: Yanbo Liang <yb...@gmail.com>
Date:   2017-07-28T10:29:41Z

    Remove unnecessary Python tests.

commit 9ea523861dac3697f1e96d2d6ea6479d070a6c03
Author: Yanbo Liang <yb...@gmail.com>
Date:   2017-07-28T11:31:28Z

    Add test cases.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    **[Test build #80019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80019/testReport)** for PR 18759 at commit [`9ea5238`](https://github.com/apache/spark/commit/9ea523861dac3697f1e96d2d6ea6479d070a6c03).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    **[Test build #80024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80024/testReport)** for PR 18759 at commit [`54759c4`](https://github.com/apache/spark/commit/54759c4fd977bd0ffdbc60737ed2cc4f4dc2cc4f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by yanboliang <gi...@git.apache.org>.

Github user yanboliang commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    @BryanCutler I linked this PR to the JIRA manually. Thanks for remind.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by zero323 <gi...@git.apache.org>.

Github user zero323 commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    Thanks @yanboliang 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by yanboliang <gi...@git.apache.org>.

Github user yanboliang commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    Merged into master, thanks for reviewing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    **[Test build #80024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80024/testReport)** for PR 18759 at commit [`54759c4`](https://github.com/apache/spark/commit/54759c4fd977bd0ffdbc60737ed2cc4f4dc2cc4f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by BryanCutler <gi...@git.apache.org>.

Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    @yanboliang , I'm not sure why but this PR did not make it onto the JIRA.  I've noticed it has happened a couple times elsewhere too, maybe some script is broken?  Just fyi, if you want to add a link manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18759: [SPARK-20601][ML] Python API for Constrained Logistic Re...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18759
  
    **[Test build #80019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80019/testReport)** for PR 18759 at commit [`9ea5238`](https://github.com/apache/spark/commit/9ea523861dac3697f1e96d2d6ea6479d070a6c03).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org