You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/22 12:30:41 UTC

[GitHub] [jackrabbit] reschke commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4

reschke commented on code in PR #128:
URL: https://github.com/apache/jackrabbit/pull/128#discussion_r977595502


##########
jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java:
##########
@@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {
                 return n;
             }
 
+            @Override
             public void remove() {
                 throw new UnsupportedOperationException("remove");
             }
-

Review Comment:
   I stumbled across this as well; the original code apparently tried to protect itself against modifcations through other methods. Can we really eliminate this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org