Re: [PR] Add test that illustrates float text parse bug [daffodil]

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence commented on code in PR #1132:
URL: https://github.com/apache/daffodil/pull/1132#discussion_r1439461522


##########
daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml:
##########
@@ -3719,6 +3722,17 @@
     </tdml:infoset>
   </tdml:parserTestCase>
 
+  <tdml:parserTestCase name="float_text_delim" root="floatTextDelim"
+                       model="SimpleTypes-Embedded.dfdl.xsd" description="Section 5 Simple type-float - DFDL-5-008R">
+
+    <tdml:document><![CDATA[3.4028235E38]]></tdml:document>

Review Comment:
   Fields with `lengthKind="delimited"` can be delimited by more than just separators, including EOF. From the spec:
   
   > On parsing, the length of an element with dfdl:lengthKind 'delimited' is determined by scanning the data stream for the delimiter.
   > 
   > The data stream is scanned for any of
   > ·         the element's terminator (if specified)
   > ·         an enclosing construct's separator or terminator
   > ·         the end of an enclosing element designated by its known length
   > ·         the end of the data stream
   
   So the dfdl:separator="%SP;" isn't really needed in this case, but it doesn't hurt.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org