You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:45:22 UTC

[GitHub] [flume] iijima-satoshi opened a new pull request, #368: FLUME-3320 Fix taildir source reset position bug

iijima-satoshi opened a new pull request, #368:
URL: https://github.com/apache/flume/pull/368

   https://issues.apache.org/jira/browse/FLUME-3320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flume] iijima-satoshi commented on pull request #368: FLUME-3320 Fix taildir source reset position bug

Posted by GitBox <gi...@apache.org>.
iijima-satoshi commented on PR #368:
URL: https://github.com/apache/flume/pull/368#issuecomment-1123695601

   [#297](https://github.com/apache/flume/pull/297) is duplicated with this and is not sufficient to prevent this problem.
   The reason is the following ([my Jira comment](https://issues.apache.org/jira/browse/FLUME-3320?focusedCommentId=17528519&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17528519
   )).
   
   > I've met the same problem recently. This is because inode, filesize and lastModifiedTime are retrieved at different times.
   > To resolve this completely, it is necessary to retrieve these at the same time. I created a PR for this.
   
   Therefore, if this PR is applied, [#297](https://github.com/apache/flume/pull/297) is unnecessary.
   
   Other 11 PRs are derived from different problems and this PR would not affect the other PRs.
   
   Additionally, I commented some PRs that I can understand.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flume] rgoers commented on pull request #368: FLUME-3320 Fix taildir source reset position bug

Posted by GitBox <gi...@apache.org>.
rgoers commented on PR #368:
URL: https://github.com/apache/flume/pull/368#issuecomment-1272221074

   Is it possible to create a test that fails without this change and succeeds when it is applied? How can I verify this fixes the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flume] rgoers commented on pull request #368: FLUME-3320 Fix taildir source reset position bug

Posted by GitBox <gi...@apache.org>.
rgoers commented on PR #368:
URL: https://github.com/apache/flume/pull/368#issuecomment-1122797542

   There are 12 open PRs against taildir source. Before applying this I really need to know if this causes any of the other PRs to be moot. Or looking at it from the other perspective, if those PRs are applied what impact will they have on this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flume.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org