You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by przygienda <gi...@git.apache.org> on 2016/12/08 04:20:00 UTC
[GitHub] thrift pull request #1137: Implement CONST support
GitHub user przygienda opened a pull request:
https://github.com/apache/thrift/pull/1137
Implement CONST support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maximg/thrift dev-rust-thrift
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1137
----
commit 8150a148152b4b81a809b9969851533963390e69
Author: Simon G�nier <s...@simon.coffee>
Date: 2014-12-15T17:21:42Z
Initial commit for Rust support.
commit 80a053adc2251dc99949a9eeb24f2176709836d0
Author: maximg <ma...@gmail.com>
Date: 2014-12-15T18:59:51Z
Merge pull request #1 from sgnr/rust-compiler
Initial commit for Rust support.
commit 20ca592b9272fd3d5955a15d795809a1bc9a9dd8
Author: Maxim Golov <ma...@gmail.com>
Date: 2014-12-15T20:07:20Z
Initial version of the client
commit a3a7eec4196a34b66aa93ac6af3d545270825680
Author: Maxim Golov <go...@localhost.localdomain>
Date: 2014-12-15T20:12:06Z
Pick up changes from Simon for Rust support.
commit ec5b4aa5f9d4696cfffaa3565048ab2970e90354
Author: Maxim Golov <ma...@gmail.com>
Date: 2014-12-16T06:22:45Z
Added simple arg and return generation for calls
commit 53654120033c05fe62ac2f00b664f58aff7cc4f0
Author: Maxim Golov <ma...@gmail.com>
Date: 2014-12-18T09:34:25Z
Cleaned up rust_client slightly
commit 55f1a82fc152e6da83fb3a3d0fd6167ec1aa6a1b
Author: Maxim Golov <ma...@gmail.com>
Date: 2014-12-18T09:57:00Z
Added ThriftBufferedTransport
commit 8e1d20b766252ccc951e71b60fd24e2a92224362
Author: Maxim Golov <ma...@gmail.com>
Date: 2014-12-18T10:10:46Z
Added TSocket stub
commit 9ed2dba7624dd27834d365c3744e9214f71f2258
Author: Maxim Golov <ma...@gmail.com>
Date: 2014-12-19T01:27:49Z
Added TSocket methods, some error handling, replaced host parameter with String
commit ac8a2637335366a139441250cb940d86f3f22e34
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-11T17:06:22Z
First ping from client to server
commit 1e698a89cfbd869e57015edd0aee1ef62b16ddf4
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-11T20:42:37Z
Added Cargo build file and rust-thrift dependency
commit bec4ee02a506e7ac3f8c7bf7e5e699830485e438
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-11T22:24:37Z
Send and receive pings
commit 52a6a647f8975a15d0c967e57bc94a600c2e340e
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-12T03:56:50Z
Added calculator::add method to the client
commit 12ef7228e0b8e9f941f6b111f732a57c59431e44
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-12T04:07:44Z
Wrap operation result in Option
commit 73ad8b403b8acee6025d241989423939f8b8a460
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-13T22:31:44Z
Updated .gitignore for Rust tutorial
commit 016b82fd56f879209365f94f24515bb53c684da0
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-13T22:32:19Z
Fixed warnings
commit db78568f61bdd0bbc8642ed52f73e5ff94f515ae
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-13T23:26:47Z
Merge branch 'dev-rust-thrift' of https://github.com/maximg/thrift into dev-rust-thrift
commit 57c29c72afbc41bf09b1f50c7fb8894d093dfa17
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-13T23:47:50Z
Merge branch 'dev-rust-thrift' of https://github.com/maximg/thrift into dev-rust-thrift
commit bff9b7229af4e4f0e4a6abde852f741dddd82896
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-14T01:56:40Z
Implemented protocol::skip
commit aa93d61c1775412d8edcd714464442a365217ddb
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-14T02:09:58Z
Merge remote-tracking branch 'upstream/master'
commit a3900b0f2361ec7ac46182c9b68b95be10cf3938
Author: Simon G\ufffd\ufffdnier <s...@simon.coffee>
Date: 2015-01-15T03:24:22Z
Just copy the Rust lib instead of having a submodule.
commit fac465e298e535226b1bd965c4a6e92129e59903
Author: Simon G�nier <s...@simon.coffee>
Date: 2015-01-15T04:06:24Z
Indent with 4 spaces instead of 2.
commit 75ba97c7371fac1ae8f667a4a6fa455a6202195d
Author: Simon G�nier <s...@simon.coffee>
Date: 2015-01-15T04:07:53Z
Remove redundant license.
commit 700392a358b7586659eb2025f928e64f12a6559e
Author: Simon G�nier <s...@simon.coffee>
Date: 2015-01-15T04:11:21Z
Remove travis file not in root.
commit b1f8afceabde047e31d056f643feb7e5ff572e94
Author: maximg <ma...@gmail.com>
Date: 2015-01-15T07:00:49Z
Merge pull request #2 from sgnr/rust/no-submodule
Just copy the Rust lib instead of having a submodule.
commit 1a9c973c42bd2f2ed81be6ffc55ec5da81b4ab32
Author: Simon G�nier <s...@simon.coffee>
Date: 2015-01-15T03:51:15Z
Fix warnings about Copy. Silence warnings about unstable.
commit ab571c2cf164a868074ba353bf8cd9a5f3791b0f
Author: maximg <ma...@gmail.com>
Date: 2015-01-15T13:26:04Z
Merge pull request #4 from sgnr/rust/fix-warning-2015-01-14
Fix warnings about Copy. Silence warnings about unstable.
commit 3951518dee7cda94b41bd4db0aae978f8edd4a02
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-16T19:55:58Z
Added Calculate operation and Readable trait
commit e1537e77b23ad3460a1aa96b2b28f3075aa5e580
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-17T08:38:08Z
Fixed writing the comment field by using matching
commit a210f0d441fb2f50d98828b32f4c61c9a984b2d0
Author: Maxim Golov <ma...@gmail.com>
Date: 2015-01-17T11:11:20Z
Started work on the compiler: added wrapping for optional fields
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by przygienda <gi...@git.apache.org>.
Github user przygienda commented on the issue:
https://github.com/apache/thrift/pull/1137
have a first rudimentary implementation of that on my branch. On top added something that allows to plug custom traits into the generated code (I used that to implement over redis-rs a trait to have REDIS persistency support). Looks like Thrift is moving pretty slowly and Rust for Thrift diverged into couple of branches ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by maximg <gi...@git.apache.org>.
Github user maximg commented on the issue:
https://github.com/apache/thrift/pull/1137
@przygienda Rust for Thrift is developed in https://github.com/terminalcloud/thrift, if you want to get your changes upstream, could you open a merge request there? @Jens-G I believe this MR should be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1137
The description of this does not match the contents. We need to merge Rust first before we can patch it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1137
@anatol, please read the entire thread.
The bottom line is that we (Thrift) patiently wait for @maximg to make the PR for Rust support. It's their code, therefore it is their decision whether or not they think that the Rust code is ready. This PR is from someone else not involved in the Thrift Rust stuff.
> Having Thrift-Rsut integration is mutually beneficial for both projects. So I would like to this this PR resolved.
I fully agree with you. If you want to speed up things by contributing, I could imagine that @maximg will be happy to get some feedback from third-party eyes. You should talk to him.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1137
@maximg: Any comments from your side? Is this the merge request for Rust support just poorly named? Something is strange here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by maximg <gi...@git.apache.org>.
Github user maximg commented on the issue:
https://github.com/apache/thrift/pull/1137
Strange indeed, why would @przygienda try to push something from my repository. Please ignore this merge request for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by anatol <gi...@git.apache.org>.
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1137
I googled the state of rust/thrift and found that the original repo from https://github.com/maximg/thrift has been abandoned, the development later moved to https://github.com/terminalcloud/thrift that also been abandoned and later picked up by https://github.com/jsgf/thrift/tree/rust that at this point contains the most complete set of rust changes.
There is also a ticked filed to track the Rust integration activity https://issues.apache.org/jira/browse/THRIFT-2945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by anatol <gi...@git.apache.org>.
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1137
Rust is getting popular in service-side development world. Having Thrift-Rsut integration is mutually beneficial for both projects. So I would like to this this PR resolved.
Does anybody work on cleanup/upstreaming changes from above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1137: Implement CONST support
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1137
@jfarrell could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1137: Implement CONST support
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/1137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---