You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 08:07:46 UTC
[GitHub] [arrow-rs] ritchie46 opened a new pull request #329: inline PrimitiveArray::value
ritchie46 opened a new pull request #329:
URL: https://github.com/apache/arrow-rs/pull/329
This PR add `#[inline]` tags to `PrimitiveArray::value` and `PrimitiveArray::value_unchecked`, both do simple ptr arithmetic and may benefit from inlining.
#328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on pull request #329: inline PrimitiveArray::value
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #329:
URL: https://github.com/apache/arrow-rs/pull/329#issuecomment-845223158
Thanks @ritchie46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan merged pull request #329: inline PrimitiveArray::value
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #329:
URL: https://github.com/apache/arrow-rs/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #329: inline PrimitiveArray::value
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #329:
URL: https://github.com/apache/arrow-rs/pull/329#issuecomment-844854475
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#329](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be9ccdb) into [master](https://codecov.io/gh/apache/arrow-rs/commit/7f37a7f2a119dd83c497766265707a64d9b82307?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f37a7f) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head be9ccdb differs from pull request most recent head fda12d3. Consider uploading reports for the commit fda12d3 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/329/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 82.52% 82.52% -0.01%
==========================================
Files 162 162
Lines 44021 44021
==========================================
- Hits 36329 36328 -1
- Misses 7692 7693 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow-rs/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3ByaW1pdGl2ZS5ycw==) | `92.93% <ø> (ø)` | |
| [arrow/src/array/transform/boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/329/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9ib29sZWFuLnJz) | `76.92% <0.00%> (-7.70%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7f37a7f...fda12d3](https://codecov.io/gh/apache/arrow-rs/pull/329?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org