You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Greg Bowyer (JIRA)" <ji...@apache.org> on 2012/05/16 02:26:06 UTC
[jira] [Created] (LUCENE-4059) prepare-webpages breaks the build if
there are none URI complement characters in the path
Greg Bowyer created LUCENE-4059:
-----------------------------------
Summary: prepare-webpages breaks the build if there are none URI complement characters in the path
Key: LUCENE-4059
URL: https://issues.apache.org/jira/browse/LUCENE-4059
Project: Lucene - Java
Issue Type: Bug
Components: general/build
Affects Versions: 4.0
Reporter: Greg Bowyer
Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
This causes the process-webapps target to fail since XSL rejects none URI characters.
I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4059) prepare-webpages breaks the build
if there are none URI complement characters in the path
Posted by "Greg Bowyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276368#comment-13276368 ]
Greg Bowyer commented on LUCENE-4059:
-------------------------------------
My build.xml is the same as upstream, the problem is my checkout path looks like this
/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}
This means that the prepare-webpages target gets its paths in the buildpaths variable as a pipe separated list like so
{{/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}/lucene/analysis/common/build.xml|/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}/lucene/analysis/icu/build.xml|...}}
XSLT picks this up later and tries to load these paths, however XSLT assumes that they are URLS which makes the { character invalid and causes
{{com.sun.org.apache.xalan.internal.xsltc.TransletException: javax.xml.transform.TransformerException: com.sun.org.apache.xml.internal.utils.URI$MalformedURIException: Path contains invalid character: { }}
This pattern is infrastructural to where I work and is not likely to change (I would like it too)
Not sure if that makes sense
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Assignee: Uwe Schindler
> Attachments: LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4059) prepare-webpages breaks the build
if there are none URI complement characters in the path
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276616#comment-13276616 ]
Uwe Schindler commented on LUCENE-4059:
---------------------------------------
Hi,
that makes sense, thanks for reporting this! I will fix this, thanks for the nice workaround patch.
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Assignee: Uwe Schindler
> Attachments: LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (LUCENE-4059) prepare-webpages breaks the
build if there are none URI complement characters in the path
Posted by "Greg Bowyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276368#comment-13276368 ]
Greg Bowyer edited comment on LUCENE-4059 at 5/16/12 12:53 AM:
---------------------------------------------------------------
My build.xml is the same as upstream, the problem is my checkout path looks like this
/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}
This means that the prepare-webpages target gets its paths in the buildpaths variable as a pipe separated list like so
/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}/lucene/analysis/common/build.xml|/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}/lucene/analysis/icu/build.xml|...(and so on)
XSLT picks this up later and tries to load these paths, however XSLT assumes that they are URLS which makes the { character invalid and causes
com.sun.org.apache.xalan.internal.xsltc.TransletException: javax.xml.transform.TransformerException: com.sun.org.apache.xml.internal.utils.URI$MalformedURIException: Path contains invalid character: {
This pattern is infrastructural to where I work and is not likely to change (I would like it too)
Not sure if that makes sense
was (Author: gbowyer@fastmail.co.uk):
My build.xml is the same as upstream, the problem is my checkout path looks like this
/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}
This means that the prepare-webpages target gets its paths in the buildpaths variable as a pipe separated list like so
{{/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}/lucene/analysis/common/build.xml|/home/buildserver/workspace/builds/{search-engineering}-solr-lucene-{trunk}/lucene/analysis/icu/build.xml|...}}
XSLT picks this up later and tries to load these paths, however XSLT assumes that they are URLS which makes the { character invalid and causes
{{com.sun.org.apache.xalan.internal.xsltc.TransletException: javax.xml.transform.TransformerException: com.sun.org.apache.xml.internal.utils.URI$MalformedURIException: Path contains invalid character: { }}
This pattern is infrastructural to where I work and is not likely to change (I would like it too)
Not sure if that makes sense
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Assignee: Uwe Schindler
> Attachments: LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4059) prepare-webpages breaks the build if
there are none URI complement characters in the path
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4059:
----------------------------------
Attachment: LUCENE-4059-URI-webpages-breakages.patch
Hi, new and improved ("more correct") patch: On my windows machine your patch broke because of the backslashes. The most correct way to do this by creating a "real" file based URI. This can be done with the Java API (new File(source) -> toURI()). This creates a 100% correct file:// URI as XSL expects (XSL wants URIs, but most interpreters like XALAN also allow file names, but using file:-URIs is more correct and straight-forward).
I will commit this now, thanks for reporting!
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Assignee: Uwe Schindler
> Attachments: LUCENE-4059-URI-webpages-breakages.patch, LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4059) prepare-webpages breaks the build if
there are none URI complement characters in the path
Posted by "Greg Bowyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Bowyer updated LUCENE-4059:
--------------------------------
Attachment: LUCENE-4059-URI-webpages-breakages.patch
Escape URI paths for XSL
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Attachments: LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4059) prepare-webpages breaks the build
if there are none URI complement characters in the path
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-4059.
-----------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Committed rev 1339097. Thanks Greg!
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Assignee: Uwe Schindler
> Fix For: 4.0
>
> Attachments: LUCENE-4059-URI-webpages-breakages.patch, LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-4059) prepare-webpages breaks the build
if there are none URI complement characters in the path
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reassigned LUCENE-4059:
-------------------------------------
Assignee: Uwe Schindler
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Assignee: Uwe Schindler
> Attachments: LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4059) prepare-webpages breaks the build
if there are none URI complement characters in the path
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276364#comment-13276364 ]
Uwe Schindler commented on LUCENE-4059:
---------------------------------------
I don't understand the problem, can you provide your build.xml? If you changed the Lucene-provided build files, this is not an issue, because those always build out of the box. If XSL does not like your own and modified build files, they are invalid XML, so fix those. The attached patch seems to work only around your invalid XML.
> prepare-webpages breaks the build if there are none URI complement characters in the path
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-4059
> URL: https://issues.apache.org/jira/browse/LUCENE-4059
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.0
> Reporter: Greg Bowyer
> Attachments: LUCENE-4059-URI-webpages-breakages.patch
>
>
> Hi all my build environment is a little weird for legacy reasons, one of these is that checkouts from version control for my build server have {} in the path.
> This causes the process-webapps target to fail since XSL rejects none URI characters.
> I have a patch that fixes this by escaping the paths first
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org