You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/07 13:29:17 UTC
[GitHub] [ozone] rakeshadr opened a new pull request, #3487: HDDS-6838. [FSO] Sets OM default to LEGACY for an older client's bucket create request
rakeshadr opened a new pull request, #3487:
URL: https://github.com/apache/ozone/pull/3487
## What changes were proposed in this pull request?
Presently, older clients can create bucket other than LEGACY bucket layout if admin sets ozone.default.bucket.layout default value to FSO or OBS.
For example, ozone.default.bucket.layout = FILE_SYSTEM_OPTIMIZED in OM server.
Say, Older Client creates a bucket, OM will use the default value and creates an FSO bucket.
Now, older client can't perform any key operations to this bucket as older client's operations not supported on FSO/OBS buckets layout types.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6838
## How was this patch tested?
Added test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #3487: HDDS-6838. [FSO] Sets OM default to LEGACY for an older client's bucket create request
Posted by GitBox <gi...@apache.org>.
mukul1987 merged PR #3487:
URL: https://github.com/apache/ozone/pull/3487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a diff in pull request #3487: HDDS-6838. [FSO] Sets OM default to LEGACY for an older client's bucket create request
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on code in PR #3487:
URL: https://github.com/apache/ozone/pull/3487#discussion_r891347526
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -270,6 +270,36 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
}
+ private BucketLayout getDefaultBucketLayout(OzoneManager ozoneManager,
+ BucketInfo bucketInfo, String volumeName, String bucketName) {
+
+ if (getOmRequest().getVersion() <
+ ClientVersion.BUCKET_LAYOUT_SUPPORT.toProtoValue()) {
+
+ if (LOG.isDebugEnabled()) {
Review Comment:
This should mostly be a LOG.info message. or we should add a metric around it to identify cases where buckets are created from older client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3487: HDDS-6838. [FSO] Sets OM default to LEGACY for an older client's bucket create request
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3487:
URL: https://github.com/apache/ozone/pull/3487#discussion_r891445250
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -270,6 +270,36 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
}
+ private BucketLayout getDefaultBucketLayout(OzoneManager ozoneManager,
+ BucketInfo bucketInfo, String volumeName, String bucketName) {
+
+ if (getOmRequest().getVersion() <
+ ClientVersion.BUCKET_LAYOUT_SUPPORT.toProtoValue()) {
+
+ if (LOG.isDebugEnabled()) {
Review Comment:
Thanks @mukul1987 . Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org