You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2024/04/20 14:27:49 UTC
[I] Rethink `USE_ALIGNED_ACCESS` macro in kvrocks code [kvrocks]
mapleFU opened a new issue, #2261:
URL: https://github.com/apache/kvrocks/issues/2261
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Motivation
Redis uses `USE_ALIGNED_ACCESS` and check memory aligned in it's code:
1. For archs like ARM, memory access should be "aligned".
2. For arch like x86, it can use some code to do optimizations
This code leaves lots of ad-hoc optimizations in kvrocks. I think we need to check our compiler supports, does this really provides any optimizations
### Solution
1. Checks `USE_ALIGNED_ACCESS` in code with compiler versions
2. Remove them if no really optimizations
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org