You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/10/02 11:40:19 UTC
Re: [PR] MINIFICPP-2178 - Move extension tests to their directories [nifi-minifi-cpp]
lordgamez commented on PR #1658:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1658#issuecomment-1742860352
The `bugprone-unchecked-optional-access` issues can be ignored, because they will be removed, but the other clang-tidy issues should be fixed before merging:
```
2023-09-26T13:33:07.1338215Z /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/rocksdb-repos/tests/DBProvenanceRepositoryTests.cpp:28:1: error: replace macro with enum [modernize-macro-to-enum,-warnings-as-errors]
2023-09-26T13:33:07.1338918Z #define TEST_PROVENANCE_STORAGE_SIZE (1024*100) // 100 KB
2023-09-26T13:33:07.1349887Z ^~~~~~~~
2023-09-26T13:33:07.1350121Z = ,
2023-09-26T13:33:07.1350987Z /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/rocksdb-repos/tests/DBProvenanceRepositoryTests.cpp:28:9: error: macro 'TEST_PROVENANCE_STORAGE_SIZE' defines an integral constant; prefer an enum instead [modernize-macro-to-enum,-warnings-as-errors]
2023-09-26T13:33:07.1352068Z #define TEST_PROVENANCE_STORAGE_SIZE (1024*100) // 100 KB
2023-09-26T13:33:07.1352312Z ^
2023-09-26T13:33:07.1353068Z /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/rocksdb-repos/tests/DBProvenanceRepositoryTests.cpp:29:9: error: macro 'TEST_MAX_PROVENANCE_STORAGE_SIZE' defines an integral constant; prefer an enum instead [modernize-macro-to-enum,-warnings-as-errors]
2023-09-26T13:33:07.1390007Z #define TEST_MAX_PROVENANCE_STORAGE_SIZE (100*1024*1024) // 100 MB
2023-09-26T13:33:07.1390384Z ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org