You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/12 13:33:26 UTC
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a change in pull request #160: MDEP-763 - Minor Improvements:
slawekjaranowski commented on a change in pull request #160:
URL: https://github.com/apache/maven-dependency-plugin/pull/160#discussion_r706838960
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -182,7 +182,7 @@
* @since 2.10
*/
@Parameter
- private String[] ignoredDependencies = new String[0];
+ private final String[] ignoredDependencies = new String[0];
Review comment:
What is benefit with final variable, which is used as Mojo parameters?
Those fields will be injected by maven/plexus so reflections on final fields is more complicated - today it is works ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org