You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/02 17:42:42 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1697: tools/configure.sh: Add --list option to list all available configurations

Ouss4 commented on a change in pull request #1697:
URL: https://github.com/apache/incubator-nuttx/pull/1697#discussion_r482251857



##########
File path: tools/configure.sh
##########
@@ -134,13 +150,7 @@ if [ ! -d ${configpath} ]; then
     echo "Directory for ${boardconfig} does not exist.  Options are:"
     echo ""
     echo "Select one of the following options for <board-name>:"
-    configlist=`find ${TOPDIR}/boards -name defconfig`
-    for defconfig in ${configlist}; do
-      config=`dirname ${defconfig} | sed -e "s,${TOPDIR}/boards/,,g"`
-      boardname=`echo ${config} | cut -d'/' -f3`
-      configname=`echo ${config} | cut -d'/' -f5`
-      echo "  ${boardname}:${configname}"
-    done
+    dumpcfgs

Review comment:
       @v01d Done.  Should we keep USAGE after that?
   
   @xiaoxiang781216 both tools/README.txt and the toplevel README.md don't detail the options, I didn't find anything to update there.
   Yes configure.c should be updated. Maybe a little bit re-worked.  For instance getopt_long will be used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org