You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/11 16:15:16 UTC
[GitHub] [nifi] simonbence opened a new pull request #5859: NIFI-9776 Adding the possibility to export flow definition with referenced services
simonbence opened a new pull request #5859:
URL: https://github.com/apache/nifi/pull/5859
This PR aims to open the possibility to export Flow Definition of a group with the referenced Controller Servcies from outside the scope of the Process Group.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim commented on pull request #5859: NIFI-9776 Adding the possibility to export flow definition with referenced services
Posted by GitBox <gi...@apache.org>.
andrewmlim commented on pull request #5859:
URL: https://github.com/apache/nifi/pull/5859#issuecomment-1065481775
For the User Guide update, I understand the thinking behind adding two main bullets. But to reduce repetition, I thought we could add something like this:
`- *Download flow definition*: This option allows the user to download the flow definition of the process group as a JSON file. The file can be used as a backup or imported into a link:https://nifi.apache.org/registry.html[NiFi Registry^] using the <<toolkit-guide.adoc#nifi_CLI,NiFi CLI>>. There are two choices when downloading a flow definition:
** *Without external services*: Controller services referenced by the selected process group but outside its scope (e.g., services in a parent group) _will not be_ included in the flow definition.
** *With external services*: Controller services referenced by the selected process group but outside its scope (e.g., services in a parent group) _will be_ included in the flow definition.
(Note: If "Download flow definition" is selected for a versioned process group, there is no versioning information in the download. In other words, the resulting contents of the JSON file is the same whether the process group is versioned or not.)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim commented on pull request #5859: NIFI-9776 Adding the possibility to export flow definition with referenced services
Posted by GitBox <gi...@apache.org>.
andrewmlim commented on pull request #5859:
URL: https://github.com/apache/nifi/pull/5859#issuecomment-1065429595
My initial impression of the UI is the same as Bryan's: "referenced" services could be downloaded with both options. It's more a matter of whether the services are in or out of the scope of the process group.
Suggested alternative:
- Without externally referenced services
- With externally referenced services
or if those are too long:
- Without external services
- With external services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #5859: NIFI-9776 Adding the possibility to export flow definition with referenced services
Posted by GitBox <gi...@apache.org>.
simonbence commented on pull request #5859:
URL: https://github.com/apache/nifi/pull/5859#issuecomment-1065265882
Hi @brandonJY ! Can you please take a look if you have some time? I think, as this change is connected to the registry, your input would be most useful. Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence edited a comment on pull request #5859: NIFI-9776 Adding the possibility to export flow definition with referenced services
Posted by GitBox <gi...@apache.org>.
simonbence edited a comment on pull request #5859:
URL: https://github.com/apache/nifi/pull/5859#issuecomment-1065265882
Hi @bbende ! Can you please take a look if you have some time? I think, as this change is connected to the registry, your input would be most useful. Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim edited a comment on pull request #5859: NIFI-9776 Adding the possibility to export flow definition with referenced services
Posted by GitBox <gi...@apache.org>.
andrewmlim edited a comment on pull request #5859:
URL: https://github.com/apache/nifi/pull/5859#issuecomment-1065481775
For the User Guide update, I understand the thinking behind adding two main bullets. But to reduce repetition, I thought we could add something like this:
```
- *Download flow definition*: This option allows the user to download the flow definition of the process group as a JSON file. The file can be used as a backup or imported into a link:https://nifi.apache.org/registry.html[NiFi Registry^] using the <<toolkit-guide.adoc#nifi_CLI,NiFi CLI>>. There are two choices when downloading a flow definition:
** *Without external services*: Controller services referenced by the selected process group but outside its scope (e.g., services in a parent group) _will not be_ included in the flow definition.
** *With external services*: Controller services referenced by the selected process group but outside its scope (e.g., services in a parent group) _will be_ included in the flow definition.
(Note: If "Download flow definition" is selected for a versioned process group, there is no versioning information in the download. In other words, the resulting contents of the JSON file is the same whether the process group is versioned or not.)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org