You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 22:26:12 UTC

[GitHub] [airflow] john-jac opened a new pull request #13521: In DagBag set read_dags_from_db from config

john-jac opened a new pull request #13521:
URL: https://github.com/apache/airflow/pull/13521

Update dagbag.py read_dags_from_db __ini__ parameter to set from config rather than default to False. This will allow CLI backfill to work from stored DAGs and also matches the read_dags_from_db behavior to match that of the other DagBag input parameters.

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] john-jac commented on pull request #13521: In DagBag set read_dags_from_db from config

Posted by GitBox <gi...@apache.org>.

john-jac commented on pull request #13521:
URL: https://github.com/apache/airflow/pull/13521#issuecomment-755809031


   Not the correct solution 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] john-jac closed pull request #13521: In DagBag set read_dags_from_db from config

Posted by GitBox <gi...@apache.org>.

john-jac closed pull request #13521:
URL: https://github.com/apache/airflow/pull/13521


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #13521: In DagBag set read_dags_from_db from config

Posted by GitBox <gi...@apache.org>.

kaxil commented on a change in pull request #13521:
URL: https://github.com/apache/airflow/pull/13521#discussion_r553030534



##########
File path: airflow/models/dagbag.py
##########
@@ -90,7 +90,7 @@ def __init__(
         include_examples: bool = conf.getboolean('core', 'LOAD_EXAMPLES'),
         include_smart_sensor: bool = conf.getboolean('smart_sensor', 'USE_SMART_SENSOR'),
         safe_mode: bool = conf.getboolean('core', 'DAG_DISCOVERY_SAFE_MODE'),
-        read_dags_from_db: bool = False,
+        read_dags_from_db: bool = conf.getboolean('core', 'STORE_DAG_CODE'),

Review comment:
       Hey John as mentioned on Slack, this won't be the correct fix, 
   
   `read_dags_from_db` decides if it should read the DAGs from DB (Serialized Dags from serialized_dag table). The `conf.getboolean('core', 'STORE_DAG_CODE')` config is only used in Webserver to show the Code (as plain strings) from the `dag_code` table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13521: In DagBag set read_dags_from_db from config

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #13521:
URL: https://github.com/apache/airflow/pull/13521#issuecomment-755755102

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

For queries about this service, please contact Infrastructure at:
users@infra.apache.org