[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration

[GitBox <gi...@apache.org>]

HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r300910806
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
 ##########
 @@ -113,6 +118,13 @@ public void testPerJobMode() throws Exception {
 
 					assertThat(jobResult, is(notNullValue()));
 					assertThat(jobResult.getSerializedThrowable().isPresent(), is(false));
+
+					final FileSystem fs = FileSystem.get(getYarnConfiguration());
+					String suffix = ".flink/" + applicationId.toString() + "/" + flinkUberjar.getName();
+
+					Path uberJarHDFSPath = new Path(fs.getHomeDirectory(), suffix);
+					FileStatus fsStatus = fs.getFileStatus(uberJarHDFSPath);
+					Assert.assertEquals(5, fsStatus.getReplication());
 
 Review comment:
   Not sure whether I understand your suggestions. This change mainly to add replica for those jar, libs, configs that are uploaded before start application master. As all of these files are go through the same function call, I think verify one of them is enough.   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services