[jira] [Commented] (OOZIE-1883) hostnameFilter has invalid url-pattern

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034265#comment-14034265 ] 

Hadoop QA commented on OOZIE-1883:
----------------------------------

Testing JIRA OOZIE-1883

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1475
.    Tests failed: 2
.    Tests errors: 1

.    The patch failed the following testcases:

.      testBundleEngineChange(org.apache.oozie.servlet.TestV1JobServletBundleEngine)
.      testBundleEngineSuspend(org.apache.oozie.servlet.TestV1JobServletBundleEngine)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1326/

> hostnameFilter has invalid url-pattern
> --------------------------------------
>
>                 Key: OOZIE-1883
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1883
>             Project: Oozie
>          Issue Type: Bug
>    Affects Versions: 3.3.2, 4.0.1
>         Environment: IBM WebSphere Liberty Profile
>            Reporter: David Villegas
>             Fix For: trunk
>
>         Attachments: OOZIE-1883.patch
>
>
> The hostnameFilter in web-common.xml is currently:
> {code:xml}
> <filter-mapping>
>     <filter-name>hostnameFilter</filter-name>
>     <url-pattern>*</url-pattern>
> </filter-mapping>
> {code}
> However, '*' is not a valid url-pattern. From the servlet 2.5 spec:
> {quote}
> In the Web application deployment descriptor, the following syntax is used to define mappings:
> * A string beginning with a ‘/’ character and ending with a ‘/*’ suffix is used
> for path mapping.
> * A string beginning with a ‘*.’ prefix is used as an extension mapping.
> * A string containing only the ’/’ character indicates the "default" servlet of
> the application. In this case the servlet path is the request URI minus the context path and the path info is null.
> * All other strings are used for exact matches only.
> {quote}
> This causes the filter to not be applied correctly in some application servers such as WASLP



--
This message was sent by Atlassian JIRA
(v6.2#6252)