You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/03/08 01:12:36 UTC

[GitHub] [incubator-teaclave-sgx-sdk] dingelish opened a new pull request #322: fix: add pointer null check on ecall function

dingelish opened a new pull request #322:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/322


   reported by @pedrotbtl and @woloszyn . thanks for contribution!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave-sgx-sdk] pedrotbtl commented on pull request #322: fix: add pointer null check on ecall function

Posted by GitBox <gi...@apache.org>.
pedrotbtl commented on pull request #322:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/322#issuecomment-792623627


   Hi @dingelish, it looks good to us! Can you just,please, correct Wojciech's handle: it is @w-woloszyn. Also, Professor Bill Roscoe is another contributor to our analysis, and to finding this issue as a consequence - he does not have a github handle, though. Just making sure everyone is acknowledged so we are all on the same page! :-D
   
   Many thanks for keeping us in the loop and for the fix!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on a change in pull request #322: fix: add pointer null check on ecall function

Posted by GitBox <gi...@apache.org>.
volcano0dr commented on a change in pull request #322:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/322#discussion_r589145260



##########
File path: samplecode/tls/tlsclient/enclave/src/lib.rs
##########
@@ -287,6 +287,10 @@ impl Sessions {
 
 #[no_mangle]
 pub extern "C" fn tls_client_new(fd: c_int, hostname: * const c_char, cert: * const c_char) -> usize {
+    if hostname.is_null() {

Review comment:
       ```
   if hostname.is_null() || cert.is_null() {
       return 0xFFFF_FFFF_FFFF_FFFF;
   }
   ```
   Please add null pointer check for tls_server_new. thanks!.
   
   ```
   pub extern "C" fn tls_server_new(fd: c_int, cert: * const c_char, key: * const c_char) -> usize 
   
   if key.is_null() || cert.is_null() {
       return 0xFFFF_FFFF_FFFF_FFFF;
   }
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave-sgx-sdk] dingelish commented on pull request #322: fix: add pointer null check on ecall function

Posted by GitBox <gi...@apache.org>.
dingelish commented on pull request #322:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/322#issuecomment-792397790


   @pedrotbtl @woloszyn please take a look. thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org


[GitHub] [incubator-teaclave-sgx-sdk] dingelish merged pull request #322: fix: add pointer null check on ecall function

Posted by GitBox <gi...@apache.org>.
dingelish merged pull request #322:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org