You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/18 03:18:22 UTC
[GitHub] [spark] viirya opened a new pull request, #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
viirya opened a new pull request, #38291:
URL: https://github.com/apache/spark/pull/38291
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This adds additional checkpoint rename file check.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We encountered an issue recently that one customer's structured streaming job failed to read delta file.
The temporary file exists but it was not successfully renamed to final delta file path.
We currently don't check if renamed file exists but assume it successful. As the result, failing to read delta file assumed to be committed in last batch makes re-triggering the job impossible.
We should be able to do a check against checkpoint renamed file to prevent such difficulty in advance.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1286370672
(Just curious about how you came through the case. Was the issue from underlying storage, or inconsistency of file system API? I can't imagine the scenario if the API works as contract and the underlying file system is stable, so...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283236439
Are the failures related?
```
[info] *** 12 TESTS FAILED ***
[error] Failed: Total 6746, Failed 12, Errors 0, Passed 6734, Ignored 5
[error] Failed tests:
[error] org.apache.spark.sql.catalyst.expressions.CastWithAnsiOffSuite
[error] org.apache.spark.sql.catalyst.util.TimestampFormatterSuite
[error] org.apache.spark.sql.catalyst.expressions.CastWithAnsiOnSuite
[error] org.apache.spark.sql.catalyst.util.RebaseDateTimeSuite
[error] org.apache.spark.sql.catalyst.expressions.TryCastSuite
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283445690
Thanks @dongjoon-hyun @HyukjinKwon @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38291:
URL: https://github.com/apache/spark/pull/38291#discussion_r998657699
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1830,6 +1830,13 @@ object SQLConf {
.stringConf
.createWithDefault("lz4")
+ val CHECKPOINT_RENAMEDFILE_CHECK_ENABLED =
+ buildConf("spark.sql.streaming.checkpoint.renamedFileCheck.enabled")
+ .doc("When true, Spark will validate if renamed checkpoint file exists.")
+ .internal()
+ .booleanConf
Review Comment:
```
.version("3.4.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38291:
URL: https://github.com/apache/spark/pull/38291#discussion_r998076086
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1830,6 +1830,13 @@ object SQLConf {
.stringConf
.createWithDefault("lz4")
+ val CHECKPOINT_RENAMEDFILE_CHECK_ENABLED =
+ buildConf("spark.sql.streaming.checkpoint.renamedFileCheck")
Review Comment:
I think maybe we usually "enabled" keyword for string when "ENABLED" is following in the postfix for option?
So, for example:
```diff
- "spark.sql.streaming.checkpoint.renamedFileCheck"
+ "spark.sql.streaming.checkpoint.renamedFileCheck.enabled"
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283333328
Synced up with master and try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283435107
Ya, `master` branch seems to be broken with the same irrelevant failures, too.
- https://github.com/apache/spark/actions/runs/3278495669/jobs/5397028188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283436016
Merged to master for Apache Spark 3.4.
Thank you, @viirya , @itholic , @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1281760137
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
URL: https://github.com/apache/spark/pull/38291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #38291:
URL: https://github.com/apache/spark/pull/38291#discussion_r998076086
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1830,6 +1830,13 @@ object SQLConf {
.stringConf
.createWithDefault("lz4")
+ val CHECKPOINT_RENAMEDFILE_CHECK_ENABLED =
+ buildConf("spark.sql.streaming.checkpoint.renamedFileCheck")
Review Comment:
I think maybe we usually use "enabled" keyword for string when "ENABLED" is following in the postfix for option?
So, for example:
```diff
- "spark.sql.streaming.checkpoint.renamedFileCheck"
+ "spark.sql.streaming.checkpoint.renamedFileCheck.enabled"
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #38291:
URL: https://github.com/apache/spark/pull/38291#discussion_r998389278
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1830,6 +1830,13 @@ object SQLConf {
.stringConf
.createWithDefault("lz4")
+ val CHECKPOINT_RENAMEDFILE_CHECK_ENABLED =
+ buildConf("spark.sql.streaming.checkpoint.renamedFileCheck")
Review Comment:
Okay. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283239173
Since the first commit passed the UT, I guess it's irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283310423
It is not. I only add `version` in the second commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #38291: [SPARK-40826][SS] Add additional checkpoint rename file check
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #38291:
URL: https://github.com/apache/spark/pull/38291#issuecomment-1283331895
Verified locally these tests are passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org