You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amar Kamat (JIRA)" <ji...@apache.org> on 2009/03/18 05:12:50 UTC
[jira] Created: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Remove dependency of testcases on RESTART_COUNT
-----------------------------------------------
Key: HADOOP-5521
URL: https://issues.apache.org/jira/browse/HADOOP-5521
Project: Hadoop Core
Issue Type: Improvement
Components: test
Affects Versions: 0.21.0
Reporter: Amar Kamat
Fix For: 0.21.0
There are 2 usecases for this :
# RESTART_COUNT is not guaranteed to be flushed to fs.
# HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-5521:
---------------------------------
Release Note: This patch makes TestJobHistory and its dependent testcases independent of RESTART_COUNT.
Status: Patch Available (was: Open)
ant test-patch gave the following:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Unit tests passed on my machine.
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5521.patch
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682993#action_12682993 ]
Amareshwari Sriramadasu commented on HADOOP-5521:
-------------------------------------------------
Patch looks fine to me.
But, should be this part of HADOOP-5394 itself ? I'm fine with it anyways.
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5521.patch
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5521:
-----------------------------------
Affects Version/s: (was: 0.21.0)
0.20.0
Fix Version/s: (was: 0.21.0)
0.20.0
Committed to branch 0.20 as well as it was required by HADOOP-5394.
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.20.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.20.0
>
> Attachments: HADOOP-5521.patch
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-5521:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Ravi!
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5521.patch
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12684000#action_12684000 ]
Hudson commented on HADOOP-5521:
--------------------------------
Integrated in Hadoop-trunk #785 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/785/])
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5521.patch
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat reassigned HADOOP-5521:
----------------------------------
Assignee: Ravi Gummadi
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5521) Remove dependency of testcases on
RESTART_COUNT
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-5521:
---------------------------------
Attachment: HADOOP-5521.patch
Earlier TestJobHistory was using RESTART_COUNT logged in history file to know that JT was restarted. Since HADOOP-5394 is removing RESTART_COUNT from history file, the new TestJobHistory assumes JT restart when launch of job is seen in history log file 2nd time.
Attaching patch that makes TestJobHistory and its dependent testcases independent of RESTART_COUNT.
Please review and provide your comments.
> Remove dependency of testcases on RESTART_COUNT
> -----------------------------------------------
>
> Key: HADOOP-5521
> URL: https://issues.apache.org/jira/browse/HADOOP-5521
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.21.0
> Reporter: Amar Kamat
> Assignee: Ravi Gummadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5521.patch
>
>
> There are 2 usecases for this :
> # RESTART_COUNT is not guaranteed to be flushed to fs.
> # HADOOP-5394 plans to discontinue logging restart-count to job history file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.