[GitHub] [pinot] ankitsultana commented on a diff in pull request #10319: [multistage] Close OpChains That Return Error-Block

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #10319:
URL: https://github.com/apache/pinot/pull/10319#discussion_r1114984941


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerServiceTest.java:
##########
@@ -144,6 +144,7 @@ public void shouldScheduleOpChainEvenIfNoOpChainsInAWhile()
     OpChain opChain = getChain(_operatorA);
     CountDownLatch latch = new CountDownLatch(3);
     AtomicBoolean returnedOpChain = new AtomicBoolean(false);
+    Mockito.when(_operatorA.nextBlock()).thenReturn(TransferableBlockUtils.getNoOpTransferableBlock());

Review Comment:
   Added this because otherwise we were getting a silent NullPointerException logged in the UTs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org