[GitHub] [incubator-pinot] mayankshriv commented on pull request #5608: Pinot Configuration Refactoring - Phase 1

[GitBox <gi...@apache.org>]

mayankshriv commented on pull request #5608:
URL: https://github.com/apache/incubator-pinot/pull/5608#issuecomment-653040032


   > > Will this be feature compatible with Apache commons configuration? For example, getting configuration object for `pinot.server`. will return another configuration object with all propoerties under `pinot.server`.
   > 
   > Isn't that achieved with the `subset` function? If so, it is already supported by the new `PinotConfiguration`. If you are referring to a return object coming from a `getProperty` call on commons `Configuration`, that can behaviour can be replicated.
   > 
   > @mayankshriv, if possible, it would be helpful for me to sync with you this week to fully understand how LinkedIn implements and wraps Pinot. That will give me better context to bring forward a refactoring that doesn't break existing large scale deployments. I'm trying to understand how Commons Configuration is used for Pinot by LinkedIn in ways that wasn't already adapted by the changes in this commit. My guess is that you use core pinot and not the service / tool wrappers provided by the OSS extensions? Thanks!
   
   @daniellavoie Sorry, I missed it earlier. I had requested @jackjlli to help review this doc. If you would still like to understand how LinkedIn is using this, I am happy to chat (would be good include @jackjlli in the conversation as well).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org