You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/03/25 08:25:55 UTC

[PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

adoroszlai opened a new pull request, #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23

   ## What changes were proposed in this pull request?
   
   Node.js 20 is [deprecated](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/) in GitHub runners.  Bump GitHub actions versions to the latest ones for Node.js 24 support (where available).
   
   Before:
   
   ```
   $ git submodule status
    a917fd15b20e8b64b94d9158ad54cd6345335584 .github/actions/chart-releaser-action (v1.4.1-18-ga917fd1)
    e6669bcd63d7cb57cb4380c33043eebe5d111992 .github/actions/chart-testing-action (v2.3.1-13-ge6669bc)
    0025e74a8c7512023d06dc019c617aa3cf561fde .github/actions/kind-action (v1.5.0-25-g0025e74)
   ```
   
   After:
   
   ```
   $ git submodule status
    cae68fefc6b5f367a0275617c9f83181ba54714f .github/actions/chart-releaser-action (v1)
    6ec842c01de15ebb84c8627d2744a0c2f2755c9f .github/actions/chart-testing-action (v2)
    ef37e7f390d99f746eb8b610417061a60e82a6cc .github/actions/kind-action (v1)
   
   $ git submodule foreach git log --oneline HEAD~1..
   Entering '.github/actions/chart-releaser-action'
   cae68fe (HEAD, tag: v1.7.0, tag: v1) update cr to v1.7.0 (#220)
   Entering '.github/actions/chart-testing-action'
   6ec842c (HEAD, tag: v2.8.0, tag: v2) Bump sigstore/cosign-installer from 3.8.1 to 4.0.0 (#184)
   Entering '.github/actions/kind-action'
   ef37e7f (HEAD, tag: v1.14.0, tag: v1, origin/main, origin/HEAD, main) Bump actions/checkout from 6.0.1 to 6.0.2 in the actions group (#156)
   ```
   
   https://issues.apache.org/jira/browse/HDDS-14833
   
   ## How was this patch tested?
   
   CI (for `test` workflow):
   https://github.com/adoroszlai/ozone-helm-charts/actions/runs/23530888085


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#issuecomment-4125546339

   Filed https://github.com/apache/infrastructure-actions/issues/589 and https://github.com/apache/infrastructure-actions/issues/590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "spacemonkd (via GitHub)" <gi...@apache.org>.
spacemonkd commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016883552


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Is it related to: https://github.com/apache/infrastructure-actions/issues/590?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "spacemonkd (via GitHub)" <gi...@apache.org>.
spacemonkd commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016862184


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Hi @adoroszlai, just a question.
   Don't they have this present directly as a version instead of a hash?
   `helm/chart-releaser-action@1.7.0`
   
   Even with the comments it is kind of odd to look at the hash and takes a little while to register.
   If possible it might be good to shift to using the version notation instead
   
   Official docs use version [notation](https://github.com/helm/chart-releaser-action?tab=readme-ov-file#example-workflow)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "spacemonkd (via GitHub)" <gi...@apache.org>.
spacemonkd commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016862184


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Hi @adoroszlai, just a question.
   Don't they have this present directly as a version instead of a hash?
   `helm/chart-releaser-action@1.7.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3017018546


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   No, the `infrastructure-actions` issue reported (and fixed) was that the specific version of `setup-uv` action used internally by `chart-releaser-action` was not allowed.  It is not related to using tag or hash for actions in our own workflows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016876194


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Using git hash is required for external (non-GitHub/Apache) actions according to Apache Infra [policy](https://infra.apache.org/github-actions-policy.html) for GitHub Actions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016876194


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Using git hash is required for external (non-GitHub/Apache) actions according to Apache Infra [policy](https://infra.apache.org/github-actions-policy.html) for GitHub Actions.  (The rationale is that tags can be force-updated to a different commit.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "spacemonkd (via GitHub)" <gi...@apache.org>.
spacemonkd commented on code in PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#discussion_r3016862184


##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Hi @adoroszlai, just a question.
   Don't they have this present directly as a version instead of a hash?
   `helm/chart-releaser-action@1.7.0`
   
   Even with the comments it is kind of odd to look at the hash and takes a little to register.
   If possible it might be good to shift to using the version notation instead



##########
.github/workflows/release.yaml:
##########
@@ -24,7 +24,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Run chart-releaser
-        uses: ./.github/actions/chart-releaser-action
+        uses: helm/chart-releaser-action@cae68fefc6b5f367a0275617c9f83181ba54714f # v1.7.0

Review Comment:
   Hi @adoroszlai, just a question.
   Don't they have this present directly as a version instead of a hash?
   `helm/chart-releaser-action@1.7.0`
   
   Even with the comments it is kind of odd to look at the hash and takes a little while to register.
   If possible it might be good to shift to using the version notation instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#issuecomment-4124666579

   @dnskr please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-14833. Bump GitHub action versions [ozone-helm-charts]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #23:
URL: https://github.com/apache/ozone-helm-charts/pull/23#issuecomment-4179236714

   Thanks @dnskr, @spacemonkd for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org