You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/09 15:28:29 UTC
[GitHub] [pulsar] andrasbeni opened a new pull request, #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
andrasbeni opened a new pull request, #17023:
URL: https://github.com/apache/pulsar/pull/17023
### Motivation
This is a continuation of #16377 to reduce code repetition in the admin client.
### Modifications
Move the functionality implemented in InvocationCallbacks to a common place.
Hide creation of CompletableFuture to be consistent with other HTTP method
implementations (e.g. asyncPutRequest).
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- [ ] `doc-not-needed`
This is pure refactoring, no behavior is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17023:
URL: https://github.com/apache/pulsar/pull/17023#issuecomment-1238475077
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17023:
URL: https://github.com/apache/pulsar/pull/17023#issuecomment-1209632080
@andrasbeni Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17023:
URL: https://github.com/apache/pulsar/pull/17023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17023:
URL: https://github.com/apache/pulsar/pull/17023#issuecomment-1234395849
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17023:
URL: https://github.com/apache/pulsar/pull/17023#issuecomment-1212928595
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17023:
URL: https://github.com/apache/pulsar/pull/17023#issuecomment-1244121571
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] andrasbeni commented on pull request #17023: [refactor][java-client] Reduce code duplication in GET requests in admin client
Posted by GitBox <gi...@apache.org>.
andrasbeni commented on PR #17023:
URL: https://github.com/apache/pulsar/pull/17023#issuecomment-1242739685
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org