[jira] [Commented] (HADOOP-15340) Fix the RPC server name usage to provide information about the metrics

["Elek, Marton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427415#comment-16427415 ] 

Elek, Marton commented on HADOOP-15340:
---------------------------------------

Thx, the review [~xyao]. I just uploaded with the modification: 1) the rules are added to the javadoc 2.) I moved the pattern to a final field.

Lambda classes are not a big deal as these rules are defined to handle the generated protobuf classes. No lambda classes there, yet.  

> Fix the RPC server name usage to provide information about the metrics
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-15340
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15340
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>    Affects Versions: 3.2.0
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HADOOP-15340.001.patch, HADOOP-15340.002.patch
>
>
> In case of multiple RPC servers in the same JVM it's hard to identify the metric data. The only available information as of now is the port number.
> Server name is also added in the constructor of Server.java but it's not used at all.
> This patch fix this behaviour:
>  1. The server name is saved to a field in Server.java (constructor signature is not changed)
>  2. ServerName is added as a tag to the metrics in RpcMetrics
>  3. The naming convention for the severs are fix.
> About 3: if the server name is not defined the current code tries to identify the name from the class name. Which is not always an easy task as in some cases the server has a protobuf generated dirty name which also could be an inner class.
> The patch also improved the detection of the name (if it's not defined). It's a compatible change as the current name is not user ad all.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org