[jira] [Commented] (WICKET-4517) Wicket-core don't export "internal" packages in OSGi manifest.

["Jordi Deu-Pons (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270611#comment-13270611 ] 

Jordi Deu-Pons commented on WICKET-4517:
----------------------------------------

I've been using beta1 with this change in an OSGi container without any problem.

 I opened a pull request on https://github.com/apache/wicket/pull/5. 

Without this change it's impossible to deploy wicket-extensions in an OSGi container, because it depends on a package that it's not exported in the core.
                
> Wicket-core don't export "internal" packages in OSGi manifest.
> --------------------------------------------------------------
>
>                 Key: WICKET-4517
>                 URL: https://issues.apache.org/jira/browse/WICKET-4517
>             Project: Wicket
>          Issue Type: Sub-task
>          Components: wicket
>    Affects Versions: 6.0.0-beta1
>            Reporter: Jordi Deu-Pons
>            Priority: Minor
>
> The default behavior of Maven Bundle Plugin is to exclude package '.' and any packages containing 'impl' or 'internal'. For this reason 'wicket-core' is not exporting 'org.apache.wicket.markup.head.internal' and 'org.apache.wicket.markup.html.internal'. 
> And 'wicket-extensions' is trying to import 'org.apache.wicket.markup.html.internal' but since it is not exported by wicket-core when you try to start it in a OSGi container it fails.
> I've solved this issue adding an <Export-Package> tag to the main pom.xml. But I wasn't able to run the tests (even without changing anything), so I don't know if there is something broken (I don't think so).
> @@ -746,6 +746,7 @@
>                              </goals>
>                              <configuration>
>                                  <instructions>
> +                                   <Export-Package>org.apache.wicket*</Export-Package>
>                                      <Import-Package>org.apache.wicket*</Import-Package>
>                                      <DynamicImport-Package>*</DynamicImport-Package>
>                                      <_nouses>true</_nouses>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira