[GitHub] [airflow] turbaszek commented on issue #11657: Better unit tests for Helm Chart

[GitBox <gi...@apache.org>]

turbaszek commented on issue #11657:
URL: https://github.com/apache/airflow/issues/11657#issuecomment-714402409


   > Honestly I think my biggest complaint now is the `self.assertEqual(a,b)` vs `assert a == b` - the later I find easier to read, and now we are using pytest for the runner it also gives better diagnostics in case of failure.
   
   +1 for assert style, I think we should fix it in all database after 2.0 - there's a tool to do that.
   
   > I think pytest fixtures are powerful, but on first seeing them they are a bit "magic" I'll grant.
   
   I think I'm ok with both - fixtures and mocking. Sometimes I prefer to use one way and in other situation I prefer the other one. 
   
   In general, I think the test style is something that we should discuss after 2.0 - we didn't want to do any changes/enforcement previously because we had a looooot of changes (pre-commits, pytest, AIP-21 and more).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org