[GitHub] safrooze opened a new pull request #9093: example/nce-loss fixes and improvements

[GitBox <gi...@apache.org>]

safrooze opened a new pull request #9093: example/nce-loss fixes and improvements
URL: https://github.com/apache/incubator-mxnet/pull/9093
 
 
   ## Description ##
   Fixes for python 2.7 and 3.6 compatibility, pylint conformity, and README improvements.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage: examples don't have test coverage at this point
   - [x] Code is well-documented: 
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Fixed division for python 3.6 compatibility
   - [x] Replaced Model.FeedForward with Module interface to get fix deprecation warning
   - [x] Removed pylint:skip-file and fixed code to conform to pylint (make lint passes)
   - [x] Pulled code for reading data and creating network into their own files to improve code organization and avoid name clashes
   - [x] Improved README
   
   ## Comments ##
   - README points to images in a personal github repo. I've added these to dmlc/web-data and will submit another PR when that PR is merged.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services