[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4009: [Improve][Connector-V2][maxcompute] spark engine support date type

["hailin0 (via GitHub)" <gi...@apache.org>]

hailin0 commented on code in PR #4009:
URL: https://github.com/apache/incubator-seatunnel/pull/4009#discussion_r1091351178


##########
seatunnel-translation/seatunnel-translation-spark/seatunnel-translation-spark-common/src/main/java/org/apache/seatunnel/translation/spark/common/serialization/InternalRowConverter.java:
##########
@@ -76,7 +77,11 @@ private static Object convert(Object field, SeaTunnelDataType<?> dataType) {
                 SeaTunnelRowType rowType = (SeaTunnelRowType) dataType;
                 return convert(seaTunnelRow, rowType);
             case DATE:
-                return (int) ((LocalDate) field).toEpochDay();
+                if (field instanceof Date ){

Review Comment:
   revert other all unrelated changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org