[GitHub] [flink] mas-chen commented on a diff in pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema

[GitBox <gi...@apache.org>]

mas-chen commented on code in PR #20164:
URL: https://github.com/apache/flink/pull/20164#discussion_r925068981


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchema.java:
##########
@@ -48,6 +48,12 @@ default void open(
             SerializationSchema.InitializationContext context, KafkaSinkContext sinkContext)
             throws Exception {}
 
+    /**
+     * Closes this kafka serialization schema and releases any system resources associated with it.
+     * If the stream is already closed then invoking this method has no effect.
+     */
+    default void close() throws Exception {}

Review Comment:
   Shouldn't this be invoked by the source reader?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org