You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/24 05:19:10 UTC
[GitHub] [trafficserver] maskit opened a new pull request #6942: Remove dup code in QUICMultiCertConfigLoader
maskit opened a new pull request #6942:
URL: https://github.com/apache/trafficserver/pull/6942
The only difference between `SSLMultiCertConfigLoader::_store_ssl_ctx` and `QUICMultiCertConfigLoader::_store_ssl_ctx` was whether it says "QUIC" on log outputs.
This commit removes the long dup code and introduces `_debug_tag()` so that derived classes can override the debug tag.
Also, this is actually for #6933. I could request or make the same change for QUICMultiCertConfigLoader but unifying the code would make more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #6942: Remove dup code in QUICMultiCertConfigLoader
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6942:
URL: https://github.com/apache/trafficserver/pull/6942#issuecomment-651409899
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #6942: Remove dup code in QUICMultiCertConfigLoader
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6942:
URL: https://github.com/apache/trafficserver/pull/6942#issuecomment-648603440
If #6933 goes to 9.0 then the same fix for QUIC should be made on 9.0 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #6942: Remove dup code in QUICMultiCertConfigLoader
Posted by GitBox <gi...@apache.org>.
maskit merged pull request #6942:
URL: https://github.com/apache/trafficserver/pull/6942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org