You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2012/03/27 03:58:37 UTC
Re: svn commit: r1305706 - in /commons/proper/dbutils/trunk/src:
main/java/org/apache/commons/dbutils/AbstractQueryRunner.java
main/java/org/apache/commons/dbutils/AsyncQueryRunner.java test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java
On 27 March 2012 02:39, <ws...@apache.org> wrote:
> Author: wspeirs
> Date: Tue Mar 27 01:39:27 2012
> New Revision: 1305706
>
> URL: http://svn.apache.org/viewvc?rev=1305706&view=rev
> Log:
> - Applied DBUTILS88v2 patch
> - Cleaned up a few things CheckStyle and FindBugs were unhappy about
>
> Modified:
> commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AbstractQueryRunner.java
> commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java
> commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/AsyncQueryRunnerTest.java
>
> Modified: commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AbstractQueryRunner.java
> URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AbstractQueryRunner.java?rev=1305706&r1=1305705&r2=1305706&view=diff
> ==============================================================================
> --- commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AbstractQueryRunner.java (original)
> +++ commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AbstractQueryRunner.java Tue Mar 27 01:39:27 2012
> @@ -33,20 +33,21 @@ import java.util.Arrays;
> import javax.sql.DataSource;
>
> /**
> - * The base class for QueryRunner & AsyncQueryRunner.
> - * This class is thread safe.
> + * The base class for QueryRunner & AsyncQueryRunner. This class is thread safe.
> + *
> * @since 1.4 (mostly extracted from QueryRunner)
> */
> public abstract class AbstractQueryRunner {
> /**
> - * Is {@link ParameterMetaData#getParameterType(int)} broken (have we tried it yet)?
> + * Is {@link ParameterMetaData#getParameterType(int)} broken (have we tried
> + * it yet)?
> */
> private volatile boolean pmdKnownBroken = false;
>
> /**
> * The DataSource to retrieve connections from.
> */
> - protected final DataSource ds;
> + private final DataSource ds;
That will break binary compatibility.
There is a public method which gives access to the field, but some
code may use the direct reference.
The field should remain protected, but could be deprecated with a view
to possibly removing it at a later stage.
Since the field is final, it does not particularly matter that there
is direct access to it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org