You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/03 02:52:30 UTC

[GitHub] [beam] bntnam commented on a change in pull request #13439: [Website revamp][11179 - 11180 - 11183] Implemented Quotes component, Header and Navbar

bntnam commented on a change in pull request #13439:
URL: https://github.com/apache/beam/pull/13439#discussion_r534628628



##########
File path: website/www/site/layouts/index.html
##########
@@ -154,6 +135,35 @@ <h4 class="calendar-card-small-title">
   </div>
 {{ end }}
 
+{{ define "quotes-section" }}
+  <div class="quotes">
+    <div class="quotes-title">
+      They tried it out
+    </div>
+    <div class="quotes-content">
+      {{ $data := index $.Site.Data .Site.Language.Lang }}
+      {{ range $quote := $data.quotes }}
+          {{ partial "quotes/quote.html" (dict "icon" $quote.icon "text" $quote.text  "logoUrl" $quote.logoUrl) }}
+      {{ end }}
+    </div>
+  </div>
+{{ end }}
+
+{{ define "quotes-mobile-section" }}
+  <div class="quotes-mobile">
+    <div class="quotes-mobile-title">
+      They tried it out
+    </div>
+    <div id="my-keen-slider" class="keen-slider">

Review comment:
       I tried and I figured out that the external library was using this id to render an element on browser so we should leave it as default. I can write a comment here if you want.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org