You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/13 06:44:33 UTC
[jira] [Commented] (FLINK-3610) Scala DataStream#addSink returns
Java DataStreamSink
[ https://issues.apache.org/jira/browse/FLINK-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192147#comment-15192147 ]
ASF GitHub Bot commented on FLINK-3610:
---------------------------------------
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1784
[FLINK-3610][api-breaking][streaming] Introduced Scala DataStreamSink
The change is effectively already tested in `DataStreamTest`.
It might make sense to introduce further testing that ensures that all the scala api method calls returning data stream variants reamin in the scala api.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink FLINK-3610
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1784
----
commit 789af80b8a30f11da912a47a30d57e9dc8c317b1
Author: Márton Balassi <mb...@apache.org>
Date: 2016-03-13T05:29:45Z
[FLINK-3610][api-breaking][streaming] Introduced Scala DataStreamSink
----
> Scala DataStream#addSink returns Java DataStreamSink
> ----------------------------------------------------
>
> Key: FLINK-3610
> URL: https://issues.apache.org/jira/browse/FLINK-3610
> Project: Flink
> Issue Type: Bug
> Components: Scala API, Streaming
> Affects Versions: 1.0.0
> Reporter: Márton Balassi
> Assignee: Márton Balassi
> Priority: Critical
> Fix For: 1.0.1
>
>
> I have just come across a shortcoming of the streaming Scala API: it completely lacks the Scala implementation of the DataStreamSink and instead the Java version is used. [1]
> I would regard this as a bug that needs a fix for 1.0.1. Unfortunately this is also api-breaking.
> [1] https://github.com/apache/flink/blob/master/flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala#L928-L929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)