[jira] [Commented] (JCRVLT-354) False warnings for files not being included in the package due to being outside of filter roots

["Stefan Seifert (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964400#comment-16964400 ] 

Stefan Seifert commented on JCRVLT-354:
---------------------------------------

i'm not sure if its the same problem, but with the latest 1.0.5-SNAPSHOT version of the plugin i do not only get the warnings described above, but the build fails completely (with the sample-content package project listed above):
{noformat}
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:validate-package (default-validate-package) @ mycompany.myprojectgroup.myproject1.sample-content ---
[INFO] Start validating package 'D:\Develop\github\filevault-package-maven-plugin-1.0.4-validation-issues\content-packages\sample-content\target\myproject1-sample-content-1.0.0-SNAPSHOT.zip'...
[INFO] Using 9 validators for package of type CONTENT: jackrabbit-filter (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator), jackrabbit-properties (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator), jackrabbit-docviewparser (org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator), jackrabbit-dependencies (org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator), jackrabbit-emptyelements (org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator), jackrabbit-mergelimitations (org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator), jackrabbit-oakindex (org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator), jackrabbit-packagetype (org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator), jackrabbit-primarynodetype (org.apache.jackrabbit.vault.validation.spi.impl.PrimaryNodeTypeValidator)
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/content/dam' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF\vault\filter.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content/dam' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root\content\dam\.content.xml, nodePath=/content/dam, line=4
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/experience-fragments' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/experience-fragments, line=7
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/usergenerated' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/usergenerated, line=10
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/communities' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/communities, line=15
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/sites' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/sites, line=16
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content' is not covered by any of the filter rules but that node is a given root (either by a dependency or by the known roots). Remove that node!", filePath=jcr_root\content\.content.xml, nodePath=/content, line=4
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/campaigns' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/campaigns, line=14
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/forms' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/forms, line=17
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/community' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/community, line=18
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/projects' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/projects, line=9
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/screens' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/screens, line=11
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/content/dam' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root\content\.content.xml, nodePath=/content/dam, line=6
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/catalogs' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/catalogs, line=12
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/cq:tags' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/cq:tags, line=8
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/launches' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/launches, line=13
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy' is not contained in any of the filter rules", filePath=jcr_root\content\.content.xml, nodePath=/content/rep:policy, line=5
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.130 s
[INFO] Finished at: 2019-10-31T22:45:40+01:00
[INFO] Final Memory: 35M/651M
[INFO] ------------------------------------------------------------------------
{noformat}

it's correct that nodes like {{/content/usergenerated}} are not included in the package - they are only there because the parent node is an ordered node and when extracting the package the included nodes should be placed at the correct order position between the other nodes. this structure is created automatically by the package manger and should not lead to validation errors.

> False warnings for files not being included in the package due to being outside of filter roots
> -----------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-354
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-354
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.4
>            Reporter: Stefan Seifert
>            Assignee: Konrad Windszus
>            Priority: Major
>
> the new check introduced in JCRVLT-321 produces false warnings in my case - or i do not understand why the warning occurs.
> here is a sample project:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/sample-content
> i can understand these warnings
> {noformat}
> [WARNING] File content-packages\sample-content\jcr_root\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> {noformat}
> although it's a pity they are reported because usually these .content.xml files "above" the filter paths help creating in between nodes when the package is extracted and the parent paths of the filter do not exist yet.
> but i do not understand these warnings as the files are definitely included in the filter:
> {noformat}
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\chicago.jpg\_jcr_content\renditions\original.dir\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\nature.jpg\_jcr_content\renditions\original.dir\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\cq5dam.web.1280.1280.jpeg.dir\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\dam\myproject1\prague.jpg\_jcr_content\renditions\original.dir\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\myproject1\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> [WARNING] File content-packages\sample-content\jcr_root\content\myproject1\en\.content.xml not covered by a filter rule and therefore not contained in the resulting package
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)