You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Oliver Lietz <ap...@oliverlietz.de> on 2014/10/01 16:26:17 UTC

Re: [VOTE] Release Apache Sling Superimposing Resource Provider 0.2.0

On Monday 29 September 2014 23:12:01 Stefan Seifert wrote:
> Hi,
> 
> This is the initial release of the 'Superimposing Resource Provider' from
> contrib:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12328740

hi Stefan,

this looks confusing to me:

    /**
     * @return Root path (source path)
     */
    String getRootPath();

    /**
     * @return Target path (destination path)
     */
    String getSourcePath();

Is it intended?

The README is well done. We should make such READMEs mandatory ;)

Regards,
O.

[...]
> stefan

Re: [VOTE] Release Apache Sling Superimposing Resource Provider 0.2.0

Posted by Carsten Ziegeler <cz...@apache.org>.
+1

2014-10-01 16:40 GMT+02:00 Stefan Seifert <ss...@pro-vision.de>:

> ah, you are correct, the javadoc is confusing, leftover of some renamings
> in the past (the API itself is correct).
>
> this is fixed in rev. 1628716
>
> stefan
>
> >-----Original Message-----
> >From: Oliver Lietz [mailto:apache@oliverlietz.de]
> >Sent: Wednesday, October 01, 2014 4:26 PM
> >To: dev@sling.apache.org
> >Subject: Re: [VOTE] Release Apache Sling Superimposing Resource Provider
> >0.2.0
> >
> >On Monday 29 September 2014 23:12:01 Stefan Seifert wrote:
> >> Hi,
> >>
> >> This is the initial release of the 'Superimposing Resource Provider'
> from
> >> contrib:
> >> https://issues.apache.org/jira/browse/SLING/fixforversion/12328740
> >
> >hi Stefan,
> >
> >this looks confusing to me:
> >
> >    /**
> >     * @return Root path (source path)
> >     */
> >    String getRootPath();
> >
> >    /**
> >     * @return Target path (destination path)
> >     */
> >    String getSourcePath();
> >
> >Is it intended?
> >
> >The README is well done. We should make such READMEs mandatory ;)
> >
> >Regards,
> >O.
> >
> >[...]
> >> stefan
>



-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

RE: [VOTE] Release Apache Sling Superimposing Resource Provider 0.2.0

Posted by Stefan Seifert <ss...@pro-vision.de>.
ah, you are correct, the javadoc is confusing, leftover of some renamings in the past (the API itself is correct).

this is fixed in rev. 1628716

stefan

>-----Original Message-----
>From: Oliver Lietz [mailto:apache@oliverlietz.de]
>Sent: Wednesday, October 01, 2014 4:26 PM
>To: dev@sling.apache.org
>Subject: Re: [VOTE] Release Apache Sling Superimposing Resource Provider
>0.2.0
>
>On Monday 29 September 2014 23:12:01 Stefan Seifert wrote:
>> Hi,
>>
>> This is the initial release of the 'Superimposing Resource Provider' from
>> contrib:
>> https://issues.apache.org/jira/browse/SLING/fixforversion/12328740
>
>hi Stefan,
>
>this looks confusing to me:
>
>    /**
>     * @return Root path (source path)
>     */
>    String getRootPath();
>
>    /**
>     * @return Target path (destination path)
>     */
>    String getSourcePath();
>
>Is it intended?
>
>The README is well done. We should make such READMEs mandatory ;)
>
>Regards,
>O.
>
>[...]
>> stefan