[jira] [Updated] (HADOOP-9413) Introduce common utils for File#setReadable/Writable/Executable and File#canRead/Write/Execute that work cross-platform

["Ivan Mitic (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Mitic updated HADOOP-9413:
-------------------------------

    Attachment: HADOOP-9413.commonfileutils.patch

Attaching early version of the patch. At this point I'm looking for feedback on some points from below. I also have to do some additional testing.

A few points I'm interesting in hearing other peoples opinion:
1. At the moment, I did not expose File#set* APIs that accept the {{ownerOnly}} parameter. Adding this is strait forward, the only question is whether we need it. I didn't find use-cases in Common and HDFS projects, but I've seen some in Yarn (only on one or two places, and those could be changed to use chmod instead).
2. For File#canRead/canWrite/canExecute I check whether the current user has read/write/execute permissions on the given File thru winutils. This is generally fine from the correctness perspective as winutils provide a POSIX compatible view of Windows ACLs. However, this is different than what we did in HADOOP-8973. Will have to think a bit more about pros and cons but I'm definitely interested in getting input from others. (btw, I'm running as admin, so this makes things a bit easier for me :))
                
> Introduce common utils for File#setReadable/Writable/Executable and File#canRead/Write/Execute that work cross-platform
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9413
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9413
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-9413.commonfileutils.patch
>
>
> So far, we've seen many unittest and product bugs in Hadoop on Windows because Java's APIs that manipulate with permissions do not work as expected. We've addressed many of these problems on one-by-one basis (by either changing code a bit or disabling the test). While debugging the remaining unittest failures we continue to run into the same patterns of problems, and instead of addressing them one-by-one, I propose that we expose a set of equivalent wrapper APIs that will work well for all platforms.
> Scanning thru the codebase, this will actually be a simple change as there are very few places that use File#setReadable/Writable/Executable and File#canRead/Write/Execute (5 files in Common, 9 files in HDFS).
> HADOOP-8973 contains additional context on the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira