You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by dk...@apache.org on 2014/08/15 20:24:18 UTC
[2/2] git commit: Remove a bunch more eclipse warnings
Remove a bunch more eclipse warnings
Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/d292dbf2
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/d292dbf2
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/d292dbf2
Branch: refs/heads/master
Commit: d292dbf203998f417a20ba812451f687d951d9e7
Parents: f8f4570
Author: Daniel Kulp <dk...@apache.org>
Authored: Fri Aug 15 14:23:15 2014 -0400
Committer: Daniel Kulp <dk...@apache.org>
Committed: Fri Aug 15 14:23:15 2014 -0400
----------------------------------------------------------------------
.../src/main/java/org/apache/camel/util/ObjectHelper.java | 10 ++++++----
.../component/box/internal/LongPollingEventsManager.java | 1 -
.../main/java/org/apache/camel/maven/ApiMethodAlias.java | 1 -
.../src/main/java/org/apache/camel/maven/ApiProxy.java | 1 -
.../apache/camel/maven/FileApiMethodGeneratorMojo.java | 1 +
.../apache/camel/maven/JavadocApiMethodGeneratorMojo.java | 2 +-
.../src/main/resources/api-endpoint-config.vm | 1 -
.../src/main/resources/api-method-enum.vm | 1 -
8 files changed, 8 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java b/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
index e16e377..e769abb 100644
--- a/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
+++ b/camel-core/src/main/java/org/apache/camel/util/ObjectHelper.java
@@ -43,6 +43,8 @@ import java.util.Map;
import java.util.NoSuchElementException;
import java.util.Properties;
import java.util.Scanner;
+import java.util.Set;
+import java.util.TreeSet;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
@@ -67,10 +69,10 @@ import org.slf4j.LoggerFactory;
public final class ObjectHelper {
private static final Logger LOG = LoggerFactory.getLogger(ObjectHelper.class);
private static final String DEFAULT_DELIMITER = ",";
- @SuppressWarnings("unchecked")
- private static final List<?> PRIMITIVE_ARRAY_TYPES = Arrays.asList(byte[].class, short[].class, int[].class, long[].class,
- float[].class, double[].class, char[].class, boolean[].class);
-
+ private static final Set<Class<?>> PRIMITIVE_ARRAY_TYPES
+ = new TreeSet<Class<?>>(Arrays.asList(byte[].class, short[].class, int[].class, long[].class,
+ float[].class, double[].class, char[].class, boolean[].class));
+
/**
* Utility classes should not have a public constructor.
*/
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
----------------------------------------------------------------------
diff --git a/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java b/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
index 66bb2b7..37611b7 100644
--- a/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
+++ b/components/camel-box/src/main/java/org/apache/camel/component/box/internal/LongPollingEventsManager.java
@@ -90,7 +90,6 @@ public class LongPollingEventsManager {
}
}
- @SuppressWarnings("unused")
public void poll(long streamPosition, final String streamType, final int limit, final EventCallback callback)
throws BoxServerException, AuthFatalFailureException, BoxRestException {
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
index 8002fba..71bb89e 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiMethodAlias.java
@@ -19,7 +19,6 @@ package org.apache.camel.maven;
/**
* Represents method alias
*/
-@SuppressWarnings("unused")
public class ApiMethodAlias {
private String methodPattern;
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
index 5df0a7b..881998d 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/ApiProxy.java
@@ -25,7 +25,6 @@ import org.apache.maven.plugin.MojoExecutionException;
/**
* Represents an API to use for generating Camel Component.
*/
-@SuppressWarnings("unused")
public class ApiProxy {
private String apiName;
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
index 566ef0a..e011544 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/FileApiMethodGeneratorMojo.java
@@ -51,6 +51,7 @@ public class FileApiMethodGeneratorMojo extends AbstractApiMethodGeneratorMojo {
result.add(line);
line = reader.readLine();
}
+ reader.close();
} catch (FileNotFoundException e) {
throw new MojoExecutionException(e.getMessage(), e);
} catch (IOException e) {
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
index dd76a02..6484692 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/java/org/apache/camel/maven/JavadocApiMethodGeneratorMojo.java
@@ -78,7 +78,7 @@ public class JavadocApiMethodGeneratorMojo extends AbstractApiMethodGeneratorMoj
final Pattern excludeMethodPatterns = (excludeMethods != null) ? Pattern.compile(excludeMethods) : null;
// for proxy class and super classes not matching excluded packages or classes
- for (Class aClass = getProxyType();
+ for (Class<?> aClass = getProxyType();
aClass != null && !packagePatterns.matcher(aClass.getPackage().getName()).matches()
&& (classPatterns == null || !classPatterns.matcher(aClass.getSimpleName()).matches());
aClass = aClass.getSuperclass()) {
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
index 6bc875f..082665f 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-endpoint-config.vm
@@ -27,7 +27,6 @@ import org.apache.camel.spi.UriParams;
/**
* Camel EndpointConfiguration for $proxyType.Name
*/
-@SuppressWarnings("unused")
@UriParams
public final class $configName extends ${componentName}Configuration {
#foreach( $parameter in $parameters.entrySet() )
http://git-wip-us.apache.org/repos/asf/camel/blob/d292dbf2/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
----------------------------------------------------------------------
diff --git a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
index 0bc3056..9dab27c 100644
--- a/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
+++ b/tooling/maven/camel-api-component-maven-plugin/src/main/resources/api-method-enum.vm
@@ -32,7 +32,6 @@ import org.apache.camel.util.component.ApiMethodImpl;
/**
* Camel {@link ApiMethod} Enumeration for $proxyType.Name
*/
-@SuppressWarnings("unused")
public enum $enumName implements ApiMethod {
#foreach ( $model in $models )