[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6451: Hive: Lock hardening

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #6451:
URL: https://github.com/apache/iceberg/pull/6451#discussion_r1053007788


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -759,6 +806,29 @@ private static boolean hiveEngineEnabled(TableMetadata metadata, Configuration c
         ConfigProperties.ENGINE_HIVE_ENABLED, TableProperties.ENGINE_HIVE_ENABLED_DEFAULT);
   }
 
+  private Pair<Long, LockState> findLock(String agentInfo) throws TException, InterruptedException {
+    // Search for the locks using HMSClient.showLocks identified by the agentInfo
+    ShowLocksRequest showLocksRequest = new ShowLocksRequest();
+    showLocksRequest.setDbname(database);
+    showLocksRequest.setDbname(tableName);

Review Comment:
   should this be :
   ```suggestion
       showLocksRequest.setTableName(tableName);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org