You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/17 23:11:15 UTC

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #10254: [Broker] Remove possible error case for system topic name checking

michaeljmarshall commented on a change in pull request #10254:
URL: https://github.com/apache/pulsar/pull/10254#discussion_r615315057



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2523,7 +2523,7 @@ public boolean isAllowAutoTopicCreation(final String topic) {
 
     public boolean isAllowAutoTopicCreation(final TopicName topicName) {
         //System topic can always be created automatically
-        if (EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME.equals(topicName.getLocalName())
+        if (SystemTopicClient.isSystemTopic(topicName)

Review comment:
       `TRANSACTION_BUFFER_SNAPSHOT` was previously not included in this check. I think it is likely preferred to allow all system topics to be auto created.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org