You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/20 14:06:59 UTC
[GitHub] [kafka] lct45 opened a new pull request #11093: FIX: add serde configs to properly set serde
lct45 opened a new pull request #11093:
URL: https://github.com/apache/kafka/pull/11093
After changing the default serde to be null, some system tests started failing. This test didn't explicitly pass in a serde and didn't set the default config so when the test was trying to setup the source node it wasn't able to find any config to use and threw a config exception.
Ran the system test locally and it looked good
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lct45 commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
lct45 commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-883556982
Jenkins system tests look good, uploading isn't working but console output had:
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.8
session_id: 2021-07-20--001
run time: 7 minutes 34.256 seconds
tests run: 10
passed: 10
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.streams.streams_static_membership_test.StreamsStaticMembershipTest.test_rolling_bounces_will_not_trigger_rebalance_under_static_membership
status: PASS
run time: 1 minute 52.791 seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11093: MINOR: add serde configs to properly set serdes in failing StreamsStaticMembershipTest
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-884457416
Merged to trunk and cherrypicked to 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman edited a comment on pull request #11093: MINOR: add serde configs to properly set serdes in failing StreamsStaticMembershipTest
Posted by GitBox <gi...@apache.org>.
ableegoldman edited a comment on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-884457416
Merged to trunk and cherrypicked to 3.0 (cc @kkonstantine -- it's a system test fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lct45 commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
lct45 commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-884232748
@cadonna @ableegoldman is one of you able to merge? And potentially cherry-pick to the 3.0 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lct45 commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
lct45 commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-883423011
cc @cadonna @ableegoldman for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-884274934
Build ran into a timeout. I retriggered the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-884455762
Just some unrelated/known flaky test failures: `ConsumerBounceTest.testCloseDuringRebalance()` and `TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation` (the latter was recently fixed and the error message in the failure does not match the new code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-883493882
@lct45 I think you need to rebase on current trunk because there was a glitch on trunk that led to the failing tests for org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup() which is now fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lct45 edited a comment on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
lct45 edited a comment on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-883556982
Jenkins system tests look good, uploading isn't working but console output had:
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.8
session_id: 2021-07-20--001
run time: 7 minutes 34.256 seconds
tests run: 10
passed: 10
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.streams.streams_static_membership_test.StreamsStaticMembershipTest.test_rolling_bounces_will_not_trigger_rebalance_under_static_membership
status: PASS
run time: 1 minute 52.791 seconds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lct45 commented on pull request #11093: FIX: add serde configs to properly set serde
Posted by GitBox <gi...@apache.org>.
lct45 commented on pull request #11093:
URL: https://github.com/apache/kafka/pull/11093#issuecomment-883437311
started a system test run as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11093: MINOR: add serde configs to properly set serdes in failing StreamsStaticMembershipTest
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11093:
URL: https://github.com/apache/kafka/pull/11093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org