[PR] refactor: share window frame bound offset serialization between lower and upper bounds [datafusion-comet]

["0lai0 (via GitHub)" <gi...@apache.org>]

0lai0 opened a new pull request, #7107:
URL: https://github.com/apache/datafusion-comet/pull/7107

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #6999 
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   `CometWindowExec.windowExprToProto` serialized the lower and upper window frame bounds with two mirrored match blocks that repeated the ROWS offset evaluation, the `rangeBoundLiteral` call, and the fallback reasons. A fix applied to one bound could easily be missed on the other.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   - Add a private `boundOffset` helper that resolves a PRECEDING/FOLLOWING bound to either a ROWS row offset or a RANGE offset literal, returning the fallback reason on `Left`.
   - Each bound's match now only handles its unbounded case and `CurrentRow` itself, and maps the helper's result onto `Preceding` or `Following`.
   
   There is no behavior change. The helper runs the same checks in the same order and produces the same fallback messages, including the `lower`/`upper` wording.
   
   
   ## How are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   - Added a mirror of the existing lower bound fallback test for the upper bound (`rangeBetween(unboundedPreceding, -1L)`). Without it, passing the wrong `isLower` for the upper bound would return wrong results unnoticed. I confirmed the test catches that.
   - Both bound fallback tests now assert the fallback reason with `checkSparkAnswerAndFallbackReason`.
   
   `CometWindowExecSuite` and the window files in `CometSqlFileTestSuite` pass on Spark 4.1 (104 tests, on current main), 3.5 (93) and 3.4 (86, plus 7 group limit tests that need Spark 3.5+).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] refactor: share window frame bound offset serialization between lower and upper bounds [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove merged PR #7107:
URL: https://github.com/apache/datafusion-comet/pull/7107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org