You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/25 20:08:51 UTC

[GitHub] [spark] MaxGekk opened a new pull request #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils

MaxGekk opened a new pull request #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
URL: https://github.com/apache/spark/pull/26261
 
 
   ### What changes were proposed in this pull request?
   In the PR, I propose to move all static methods from the `CalendarInterval` class to the `IntervalUtils` object. All those methods are rewritten from Java to Scala.
   
   ### Why are the changes needed?
   - For consistency with other helper methods. Such methods were placed to the helper object `IntervalUtils`, see https://github.com/apache/spark/pull/26190
   - Taking into account that `CalendarInterval` will be fully exposed to users in the future (see https://github.com/apache/spark/pull/25022), it would be nice to clean it up by moving service methods to an internal object.
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   - By moved tests from `CalendarIntervalSuite` to `IntervalUtilsSuite`
   - By existing test suites
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org