You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/01/20 21:40:24 UTC
[GitHub] [superset] justinpark opened a new pull request, #22813: fix(sqllab): type error on renderBigIntStr
justinpark opened a new pull request, #22813:
URL: https://github.com/apache/superset/pull/22813
### SUMMARY
As titled, this commit fixes the type error on `renderBigIntStrToNumber`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- Before
```
Type '(value: string) => string' is not assignable to type '(displayValue: string | number, rawValue?: string | number | boolean | null | undefined, ...keyPath: (string | number)[]) => Element'.
```
- After
N/A
### TESTING INSTRUCTIONS
npm run type
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22813: fix(sqllab): type error on renderBigIntStr
Posted by codecov.
codecov[bot] commented on PR #22813:
URL: https://github.com/apache/superset/pull/22813#issuecomment-1400860954
# [Codecov](https://codecov.io/gh/apache/superset/pull/22813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22813](https://codecov.io/gh/apache/superset/pull/22813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc68d7c) into [master](https://codecov.io/gh/apache/superset/commit/931b01ee85702aabe7632a278e0f13837087b5a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (931b01e) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head bc68d7c differs from pull request most recent head 82d7a05. Consider uploading reports for the commit 82d7a05 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22813 +/- ##
==========================================
- Coverage 67.28% 67.28% -0.01%
==========================================
Files 1877 1877
Lines 72019 72020 +1
Branches 7897 7897
==========================================
Hits 48458 48458
- Misses 21533 21534 +1
Partials 2028 2028
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.85% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/FilterableTable/index.tsx](https://codecov.io/gh/apache/superset/pull/22813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL2luZGV4LnRzeA==) | `72.72% <0.00%> (-0.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #22813: fix(sqllab): type error on renderBigIntStr
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #22813:
URL: https://github.com/apache/superset/pull/22813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org