[jira] [Commented] (FINERACT-2664) Invalid character in URL fragment

["Adam Monsen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094130#comment-18094130 ] 

Adam Monsen commented on FINERACT-2664:
---------------------------------------

Thanks for the ping. I'm happy to take a look.

[~sebb], what is this breaking? I see that [https://fineract.apache.org|https://fineract.apache.org/] does indeed contain some standards-breaking links but it appears to be "failing" gracefully–I don't see any ill effects.

Also, [https://whimsy.apache.org/site/project/fineract] is all green (probably because it doesn't do this kind of check, but still).

If we feel strongly about standards-compliance/correctness here (and I don't, TBH) we could use %23 instead of the octothorpe in the path. E.g.: {{https://app.element.io/#/room/%23fineract:matrix.org}} 

> Invalid character in URL fragment
> ---------------------------------
>
>                 Key: FINERACT-2664
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2664
>             Project: Apache Fineract
>          Issue Type: Bug
>          Components: Docs
>            Reporter: Sebb
>            Assignee: Adam Monsen
>            Priority: Minor
>
> The website contains several links of the form:
> https://matrix.to/#/#apache-fineract-home:matrix.org
> These are not valid URLs according to RFC 3986 [1].
> This is because the character "#" is not allowed in a fragment.
> According to the RFC, a fragment cannot contain any of the 'gen-delims' characters apart from 
> ":" / "@" / "/" / "?"
> This leaves the following gen-delims as invalid:
> "#" / "[" / "]"
> [Unfortunately, many URL validators do not check this.]
> Ideally the "#" within the fragment should be encoded.
> [1] https://datatracker.ietf.org/doc/html/rfc3986.html#appendix-A



--
This message was sent by Atlassian Jira
(v8.20.10#820010)