You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "pekuz (via GitHub)" <gi...@apache.org> on 2023/06/21 07:35:25 UTC
[GitHub] [camel] pekuz opened a new pull request, #10460: Camel Azure Files component 3.x
pekuz opened a new pull request, #10460:
URL: https://github.com/apache/camel/pull/10460
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
The first draft for https://issues.apache.org/jira/browse/CAMEL-19279 to collect review comments.
# Target
- [ x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
To not interfere with ongoing Camel 3.21, a new PR for Camel 3.22 will be created, ideally incorporating feedback from current PR. In future based on demand, a port to Camel 4.x.
# Tracking
- [ x ] There is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL-19279) filed for the change.
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ x ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ 1/2 ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
format only
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602505489
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611308343
Everything is in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1600766906
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611079970
Are we going to merge this? We need to backport to main too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611375255
so essentially
git checkout camel-3.x
git pull --rebase origin (or the upstream you're pointing) camel-3.x
git checkout -b fresh-branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602492764
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #10460:
URL: https://github.com/apache/camel/pull/10460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pekuz commented on pull request #10460: Camel Azure Files component 3.x
Posted by "pekuz (via GitHub)" <gi...@apache.org>.
pekuz commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602421286
Hi Claus,
In the component doc it’s marked as
:supportlevel: Preview
I want to convey that anything can change in next release
or it could be even dropped. At the same time it’s consolidated
enough being ready for a feedback. IMHO including it in 3.21
as a preview component would significantly increase
feedback like-hood. Also the smaller step the better. So unless you
object I’m +1 to include it in 3.21 as a preview component.
I’m going to include the explanation of the preview state
in the doc too….
Hope it helps
Cc.
--
Mr. Petr Kužel, Software Engineer
Eurofins International Support Services s.à r.l.
Val Fleuri 23
L-1526 LUXEMBOURG
From: Claus Ibsen ***@***.***>
Sent: Thursday, June 22, 2023 11:25
To: apache/camel ***@***.***>
Cc: Petr Kuzel ***@***.***>; Author ***@***.***>
Subject: Re: [apache/camel] Camel Azure Files component 3.x (PR #10460)
Is there more work needed for this, as Camel 3.21 is going to be build tomorrow. Its very late, otherwise this needs to go into 3.22 released by end of this year.
—
Reply to this email directly, view it on GitHub<https://github.com/apache/camel/pull/10460#issuecomment-1602307774>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFR3WFLM34EHHXL55OHDX4LXMQFNDANCNFSM6AAAAAAZOKIYXY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602492788
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611093189
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10460: Camel Azure Files component 3.x
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602307774
Is there more work needed for this, as Camel 3.21 is going to be build tomorrow. Its very late, otherwise this needs to go into 3.22 released by end of this year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10460: Camel Azure Files component 3.x
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602427569
Any new component is automatic marked as preview for 2 releases. But this can be manually be "controlled".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1600766865
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611371083
We couldn't merge 104 commits, we had to squash in one single commit, to be also able to revert in case of errors or problems.
In a case like this, it's much more better, to start from the merged branch (camel-3.x) and work on a fresh checked-out branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602816764
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1601312167
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602548578
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pekuz commented on pull request #10460: Camel Azure Files component 3.x
Posted by "pekuz (via GitHub)" <gi...@apache.org>.
pekuz commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611407564
I understand, from that perspective it makes sense.
Yeah I have to recover after the PR merge somehow, because the discarding at the forked repo is not end of the story, the next sync with its clones tries to reintroduce the discarded commits, 105 commits ready to be pushed to the upstream, the forked repo...
It might deserve a paragraph in the doc for the contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611169021
I'm going to backport on Camel 4, the codebase, except for Jakarta migration, is mostly the same. So maintaining on both side won't be a problem. You can focus on 3.x, but we need to support this component on 4.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pekuz commented on pull request #10460: Camel Azure Files component 3.x
Posted by "pekuz (via GitHub)" <gi...@apache.org>.
pekuz commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602446366
OK, I have not known. Anyway I've added a CAUTION admonition
to explicitly manage expectations.
From: Claus Ibsen ***@***.***>
Sent: Thursday, June 22, 2023 12:51
To: apache/camel ***@***.***>
Cc: Petr Kuzel ***@***.***>; Author ***@***.***>
Subject: Re: [apache/camel] Camel Azure Files component 3.x (PR #10460)
Any new component is automatic marked as preview for 2 releases. But this can be manually be "controlled".
-
Reply to this email directly, view it on GitHub<https://github.com/apache/camel/pull/10460#issuecomment-1602427569>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFR3WFNQWBGEB4Z2INIIGJTXMQPQBANCNFSM6AAAAAAZOKIYXY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602820108
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602816792
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pekuz commented on pull request #10460: Camel Azure Files component 3.x
Posted by "pekuz (via GitHub)" <gi...@apache.org>.
pekuz commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611362363
OK, FYI from the forked repo perspective, I'm getting:
_This branch has conflicts that must be resolved_
_Discard 104 commits to make this branch match the upstream repository. 104 commits will be removed from this branch._
_You can resolve merge conflicts using the command line and a text editor._
_[Discard 104 Commits]_
I.e. the update branch option is missing. I suppose that it's a consequence of the PR merging and in particular of the commits squashing as Git cannot match the commits. Knowing the context I can understand the situation but in general for unaware contributors the only option to discard all could be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pekuz commented on pull request #10460: Camel Azure Files component 3.x
Posted by "pekuz (via GitHub)" <gi...@apache.org>.
pekuz commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611293509
@oscerd OK, thx.
IMHO the pom.xml versions might need adjustments:
<version>3.21.0-SNAPSHOT</version>
</parent>
on 3.x 3.22.0-SNAPSHOT, no? as I understand it will not be included in 3.21.
on main, I guess 4.0-SNAPSHOT
...
<properties>
<minimalJavaBuildVersion>11</minimalJavaBuildVersion>
</properties>
minimalJavaBuildVersion was fixed on main so remove, no? (but the fix was not backported to 3.x, not sure, see CAMEL-19384)
....
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-storage-file-share</artifactId>
<version>12.18.0</version> <!-- https://mvnrepository.com/artifact/com.azure/azure-storage-file-share -->
</dependency>
Here, the camel azure bom pom moved to .1 or .2. I'm not sure why I got no warning on the explicit version here. IMHO this could be eliminated in favour of the the camel azure bom pom.
Hope it helps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611106443
I'm going to squash the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1601312185
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602548552
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602505524
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1602820079
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pekuz commented on pull request #10460: Camel Azure Files component 3.x
Posted by "pekuz (via GitHub)" <gi...@apache.org>.
pekuz commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611162970
> Are we going to merge this? We need to backport to main too
At our side, we are at Camel 3, and we will unlikely be early adopters of Camel 4.
I do not know how hard would it be to port the code to main / Camel 4 and to maintain it at both branches. I can give it a try but anyway I would stay in the reverse mode: further developing the Camel Azure Files component on camel-3.x and occasionally porting to the main, provided the reconciliation gap is narrow. Once we adopt Camel 4 then I would switch to the more traditional flow, developing on main and backporting to camel-3.x as needed.
Does it make sense, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10460: Camel Azure Files component 3.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611298433
> @oscerd OK, thx.
>
> IMHO the pom.xml versions might need adjustments:
>
> ```
> <version>3.21.0-SNAPSHOT</version>
> </parent>
> ```
Once the release for 3.21.0 will be completed we'll move 3.x to 3.22.0-SNAPSHOT
>
> on 3.x 3.22.0-SNAPSHOT, no? as I understand it will not be included in 3.21. on main, I guess 4.0-SNAPSHOT
>
> ...
>
> ```
> <properties>
> <minimalJavaBuildVersion>11</minimalJavaBuildVersion>
> </properties>
> ```
>
> minimalJavaBuildVersion was fixed on main so remove, no? (but the fix was not backported to 3.x, not sure, see [CAMEL-19384](https://issues.apache.org/jira/browse/CAMEL-19384))
Yes. I'm going to remove it on main.
>
> ....
>
> ```
> <dependency>
> <groupId>com.azure</groupId>
> <artifactId>azure-storage-file-share</artifactId>
> <version>12.18.0</version> <!-- https://mvnrepository.com/artifact/com.azure/azure-storage-file-share -->
> </dependency>
> ```
>
> Here, the camel azure bom pom moved to .1 or .2. I'm not sure why I got no warning on the explicit version here.
IMHO this could be eliminated in favour of the the camel azure bom pom.
>
The version should have eliminated on both 3.x and main.
> Hope it helps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1611093226
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10460: Camel Azure Files component 3.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10460:
URL: https://github.com/apache/camel/pull/10460#issuecomment-1600333080
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org